Gauges in the mock sink should store the value not add to it (#111)

* Gauges in the mock sink should store the value not add to it * Fix tests for mock sink gauges
lyft · Jan 18, 2022 · 3c8ab33 · 3c8ab33
1 parent c412bd1
commit 3c8ab33
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 4 deletions.
diff --git a/mock/sink.go b/mock/sink.go
@@ -74,7 +74,7 @@ func (s *Sink) FlushGauge(name string, val uint64) {
 		v, _ = gauges.LoadOrStore(name, new(entry))
 	}
 	p := v.(*entry)
-	atomic.AddUint64(&p.val, val)
+	atomic.StoreUint64(&p.val, val)
 	atomic.AddInt64(&p.count, 1)
 }
 

diff --git a/mock/sink_test.go b/mock/sink_test.go
@@ -251,7 +251,6 @@ func TestSink_ThreadSafe(t *testing.T) {
 		gaugeCalls   = new(int64)
 		timerCalls   = new(int64)
 		counterVal   = new(uint64)
-		gaugeVal     = new(uint64)
 	)
 	funcs := [...]func(){
 		func() {
@@ -261,7 +260,6 @@ func TestSink_ThreadSafe(t *testing.T) {
 		},
 		func() {
 			atomic.AddInt64(gaugeCalls, 1)
-			atomic.AddUint64(gaugeVal, 1)
 			sink.FlushGauge("name", 1)
 		},
 		func() {
@@ -290,7 +288,7 @@ func TestSink_ThreadSafe(t *testing.T) {
 	sink.AssertTimerCallCount(t, "name", int(atomic.LoadInt64(timerCalls)))
 
 	sink.AssertCounterEquals(t, "name", atomic.LoadUint64(counterVal))
-	sink.AssertGaugeEquals(t, "name", atomic.LoadUint64(gaugeVal))
+	sink.AssertGaugeEquals(t, "name", uint64(1))
 }
 
 func TestSink_ThreadSafe_Reset(t *testing.T) {