Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Gauges in the mock sink should store the value not add to it #111

Merged
merged 2 commits into from
Jan 18, 2022
Merged

Gauges in the mock sink should store the value not add to it #111

merged 2 commits into from
Jan 18, 2022

Conversation

almost
Copy link
Contributor

@almost almost commented Nov 5, 2020

I noticed a bug in the mock sink. When it flushes gauges it treats them like counters which isn't correct.

fsouza
fsouza reviewed Nov 6, 2020
View reviewed changes
Copy link
Contributor

@fsouza fsouza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you also fix the test? 😁

@fsouza
Copy link
Contributor

fsouza commented Jan 18, 2022

Sorry I missed this.

@fsouza fsouza merged commit 3c8ab33 into lyft:master Jan 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fsouza fsouza fsouza approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@almost @fsouza