Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merge latest from lyft-release-sp8 #27

Merged
merged 6 commits into from
May 3, 2019
Merged

Merge latest from lyft-release-sp8 #27

merged 6 commits into from
May 3, 2019

Conversation

DiggidyDave
Copy link

feat: Scheduling queries from SQL Lab
feat: view presto row objects in data grid (apache#7436)

DiggidyDave and others added 6 commits May 1, 2019 09:11
@DiggidyDave
Merge pull request #24 from lyft/mergeLatestFromApache
d244588 
merge from apache/lyft-release-sp8
@betodealmeida
Workaround for no results returned (apache#7442)
59a81e1
@khtruong @betodealmeida
feat: view presto row objects in data grid (apache#7436)
2a003c1 
* feat: view presto row objects in data grid

* fix: address feedback

* fix: spacing
@betodealmeida
feat: Scheduling queries from SQL Lab (apache#7416)
90eef51 
* Lightweight pipelines POC

* Add docs

* Minor fixes

* Remove Lyft URL

* Use enum

* Minor fix

* Fix unit tests

* Mark props as required
Merge latest from lyft-release-sp8
eec6419 
feat: Scheduling queries from SQL Lab
feat: view presto row objects in data grid (apache#7436)
Merge latest from lyft-release-sp8
d9a299d 
feat: Scheduling queries from SQL Lab
feat: view presto row objects in data grid (apache#7436)
@xtinec
Copy link

xtinec commented May 3, 2019

👍

@codecov-io
Copy link

codecov-io commented May 3, 2019 •
edited
Loading

Codecov Report

Merging #27 into lyft-master will decrease coverage by 0.02%.
The diff coverage is 52%.

Impacted file tree graph

@@               Coverage Diff               @@
##           lyft-master      #27      +/-   ##
===============================================
- Coverage        64.02%   63.99%   -0.03%     
===============================================
  Files              438      439       +1     
  Lines            21602    21671      +69     
  Branches          2394     2399       +5     
===============================================
+ Hits             13830    13868      +38     
- Misses            7634     7665      +31     
  Partials           138      138
Impacted Files Coverage Δ
...src/components/FilterableTable/FilterableTable.jsx 91.01% <ø> (ø) ⬆️
.../assets/src/SqlLab/components/QueryAutoRefresh.jsx 11.9% <0%> (-0.92%) ⬇️
superset/views/sql_lab.py 94.64% <100%> (ø) ⬆️
superset/assets/src/featureFlags.ts 88.88% <100%> (+13.88%) ⬆️
...sets/src/SqlLab/components/ScheduleQueryButton.jsx 13.33% <13.33%> (ø)
...uperset/assets/src/SqlLab/components/SqlEditor.jsx 59.8% <50%> (-0.2%) ⬇️
superset/db_engine_specs.py 61.45% <86.11%> (+1.22%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update aea5dce...d9a299d. Read the comment docs.

@DiggidyDave DiggidyDave merged commit ebf78ba into lyft-master May 3, 2019
@DiggidyDave DiggidyDave deleted the mergeLatestToMaster branch August 19, 2019 20:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@betodealmeida betodealmeida Awaiting requested review from betodealmeida

@xtinec xtinec Awaiting requested review from xtinec

@khtruong khtruong Awaiting requested review from khtruong

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@DiggidyDave @xtinec @codecov-io @betodealmeida @khtruong