[aggregator] Prevent tcp client panic on nil placement #3139
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
When TCP Client fails to get placement from KV (f.e. on network partition) on Init() it will return an error, but placementWatcher still does the right thing and tries to reconnect to KV. Before it does so, however, it will return a nil stagedPlacement and any other client methods which read the placement will panic due to NPE.
This PR makes it return an error instead, so client's callers can retry writes on errors and once connection to KV is restored the client will pick up the placement.
Special notes for your reviewer:
Does this PR introduce a user-facing and/or backwards incompatible change?:
Does this PR require updating code package or user-facing documentation?: