Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[dbnode] Remove unused Shard.ScanData method #3148

Merged
merged 2 commits into from
Feb 2, 2021

Conversation

linasm
Copy link
Collaborator

@linasm linasm commented Feb 1, 2021

What this PR does / why we need it:
Removed some dead code.

Special notes for your reviewer:

Does this PR introduce a user-facing and/or backwards incompatible change?:


Does this PR require updating code package or user-facing documentation?:


@codecov
Copy link

codecov bot commented Feb 1, 2021

Codecov Report

Merging #3148 (9e14797) into master (7f1ce15) will decrease coverage by 0.0%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##           master    #3148     +/-   ##
=========================================
- Coverage    72.3%    72.2%   -0.1%     
=========================================
  Files        1084     1084             
  Lines      100288   100246     -42     
=========================================
- Hits        72519    72467     -52     
- Misses      22723    22736     +13     
+ Partials     5046     5043      -3     
Flag Coverage Δ
aggregator 75.8% <ø> (-0.1%) ⬇️
cluster 84.8% <ø> (ø)
collector 84.3% <ø> (ø)
dbnode 78.7% <ø> (-0.1%) ⬇️
m3em 74.4% <ø> (ø)
m3ninx 73.1% <ø> (ø)
metrics 20.0% <ø> (ø)
msg 74.2% <ø> (+0.1%) ⬆️
query 67.2% <ø> (ø)
x 80.3% <ø> (-0.3%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7f1ce15...f93b691. Read the comment docs.

@linasm linasm marked this pull request as ready for review February 2, 2021 06:42
@linasm linasm merged commit f23e2d1 into master Feb 2, 2021
@linasm linasm deleted the linasm/remove-shard-scan-data branch February 2, 2021 07:06
soundvibe added a commit that referenced this pull request Feb 2, 2021
* master:
  [dbnode] Remove unused Shard.ScanData method (#3148)
  [tests] Add option to skip setup for docker integration tests (#3146)
  [dbnode] Add source propagation to aggregate query (#3153)
  [aggregator] Prevent tcp client panic on nil placement (#3139)
soundvibe added a commit that referenced this pull request Feb 2, 2021
* master:
  [dbnode] Remove unused Shard.ScanData method (#3148)
  [tests] Add option to skip setup for docker integration tests (#3146)
  [dbnode] Add source propagation to aggregate query (#3153)
  [aggregator] Prevent tcp client panic on nil placement (#3139)
  [dtest] endpoint to fetch tagged (#3138)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants