Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unit tests fail when using .NET 7.0.3 #932

Closed
MoFtZ opened this issue Feb 14, 2023 · 2 comments · Fixed by #933
Closed

Unit tests fail when using .NET 7.0.3 #932

MoFtZ opened this issue Feb 14, 2023 · 2 comments · Fixed by #933
Labels
bug help wanted

Comments

@MoFtZ
Copy link
Collaborator

MoFtZ commented Feb 14, 2023 •
edited
Loading

On Feb 14th 2023, Microsoft released the .NET 7.0.3 (SDK 7.0.200). This is causing unit tests in our CI pipeline to fail.

After installing SDK 7.0.200, I can reproduce the failures on Windows 10 using the command line dotnet test. However, I am unable to reproduce the test failures in VS2022 (v17.4.5).
@MoFtZ MoFtZ mentioned this issue Feb 14, 2023
Merged
@lostmsu
Copy link
Contributor

lostmsu commented Feb 14, 2023

You could hold SDK at 7.0.2 until VS v17.5 is released.

@MoFtZ MoFtZ mentioned this issue Feb 15, 2023
Merged
@MoFtZ
Copy link
Collaborator Author

MoFtZ commented Feb 15, 2023

Looks like the SDK changed the IL emitted for C# extension methods that use generics. The newly added boxing instructions then caused issues when ILGPU parsed the MSIL.

I have raised #933 to fix this issue by removing the boxing.

@MoFtZ MoFtZ mentioned this issue Feb 16, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug help wanted
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Added generic constraints to fix failing unit tests on .NET 7.0.3 SDK. MoFtZ/ILGPU
2 participants
@lostmsu @MoFtZ