Support static abstract interface members #930
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lostmsu
force-pushed
the
StaticAbstractInterfaceMembers
branch
from
5203332
to
c8ef126
Compare
lostmsu
force-pushed
the
StaticAbstractInterfaceMembers
branch
2 times, most recently
from
b2ab3a3
to
7803cf8
Compare
|
@MoFtZ hm, I don't seem to be able to reproduce unit test failures locally. Besides, before the copyright year change they were passing??? |
This replaces specific GenericMath support introduced in 7bf5578 ( m4rs-mt#898 ) with generic support for static abstract interface members. Support is implemented using the constrained flag on the call instruction the same way it used to be done on virtual method calls. The call instruction with constrained flag set contains concrete type, that implements given interface, which makes it possible to find concrete method implementation to be called. fixes m4rs-mt#929
lostmsu
force-pushed
the
StaticAbstractInterfaceMembers
branch
from
7803cf8
to
1daae30
Compare
|
Updated with the latest |
MoFtZ
approved these changes
Feb 15, 2023
|
Thanks a lot for you work on this issue 👍 ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This replaces specific generic math support introduced in 7bf5578 ( #898 ) with generic support for static abstract interface members.
Support is implemented using the constrained flag on the call instruction the same way it used to be done on virtual method calls. The call instruction with constrained flag set contains concrete type, that implements given interface, which makes it possible to find concrete method implementation to be called.
fixes #929