Added support for Generic Math using net70 SDK. #898
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
m4rs-mt
force-pushed
the
feature/generic-math
branch
from
9892c55
to
7bf5578
Compare
m4rs-mt
approved these changes
Dec 5, 2022
lostmsu
added a commit
to losttech/ILGPU
that referenced
this pull request
Feb 13, 2023
This replaces specific GenericMath support introduced in 7bf5578 ( m4rs-mt#898 ) with generic support for static abstract interface members. Support is implemented using the constrained flag on the call instruction the same way it used to be done on virtual method calls. The call instruction with constrained flag set contains concrete type, that implements given interface, which makes it possible to find concrete method implementation to be called. fixes m4rs-mt#929
lostmsu
added a commit
to losttech/ILGPU
that referenced
this pull request
Feb 14, 2023
This replaces specific GenericMath support introduced in 7bf5578 ( m4rs-mt#898 ) with generic support for static abstract interface members. Support is implemented using the constrained flag on the call instruction the same way it used to be done on virtual method calls. The call instruction with constrained flag set contains concrete type, that implements given interface, which makes it possible to find concrete method implementation to be called. fixes m4rs-mt#929
lostmsu
added a commit
to losttech/ILGPU
that referenced
this pull request
Feb 14, 2023
This replaces specific GenericMath support introduced in 7bf5578 ( m4rs-mt#898 ) with generic support for static abstract interface members. Support is implemented using the constrained flag on the call instruction the same way it used to be done on virtual method calls. The call instruction with constrained flag set contains concrete type, that implements given interface, which makes it possible to find concrete method implementation to be called. fixes m4rs-mt#929
lostmsu
added a commit
to losttech/ILGPU
that referenced
this pull request
Feb 14, 2023
This replaces specific GenericMath support introduced in 7bf5578 ( m4rs-mt#898 ) with generic support for static abstract interface members. Support is implemented using the constrained flag on the call instruction the same way it used to be done on virtual method calls. The call instruction with constrained flag set contains concrete type, that implements given interface, which makes it possible to find concrete method implementation to be called. fixes m4rs-mt#929
lostmsu
added a commit
to losttech/ILGPU
that referenced
this pull request
Feb 15, 2023
This replaces specific GenericMath support introduced in 7bf5578 ( m4rs-mt#898 ) with generic support for static abstract interface members. Support is implemented using the constrained flag on the call instruction the same way it used to be done on virtual method calls. The call instruction with constrained flag set contains concrete type, that implements given interface, which makes it possible to find concrete method implementation to be called. fixes m4rs-mt#929
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #802.
Note that the functionality is only available on
net70. The feature is still marked as "preview" onnet60, and we would need to compile ILGPU with the "enable preview features" flag turned on, which we do not want to do.