breaking things #11
Merged
breaking things #11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The mod's version string now includes extra information about the sources used to build the mod. If available, it will include the checked out revision in Git and whether or not the source tree was dirty. If no information about the build can be determined, the identifier "unknown" will be used. This is being done because too many players, against our recommendation, are downloading CI artifacts or compiling the mod themselves for daily use, and are unable to provide any information about where the build came from when they inevitably ask for technical support. Not having this information available to us makes it impossible to diagnose issues over time and creates significant burden. In the future, this information will be presented in the F3 screen.
The vast majority of support tickets come from players compiling the mod JDK 9+ and trying to run it on the runtime the Minecraft launcher provides (typically JRE 8).
This is a better solution than failing when JDK 9+ is used, and means that people do not have to swap around their JAVA_HOME. For users of SDKMAN and other similar package managers, Gradle can automatically pick up local toolchain installations and re-use them.
Gradle will still download an AOJ build if none suitable are available.
…610) In `pushChunkDrawParams` the need to grow the buffer is determined by comparing the write offset to the `capacity` field. But after the buffer had been grown, the `capacity` field had been left unchanged, thereby triggering another grow on each call to `pushChunkDrawParams`, quickly running out of memory.
This mirrors vanilla behavior (see `PalettedContainer.get(index)`). Fixes #565
The `writeEnd` variable used to be set relative to the write pointer, not relative start of the buffer. This resulted in a `writeEnd` value which was far too large, allowing the buffer to overflow beyond its allocated space and into random memory, corrupting everything in its way with all the unpredictable doom one would expect from that.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.