#99 - Add Strict Typing

magento · Nov 3, 2017 · 4571d70 · 4571d70
1 parent 307de4f
commit 4571d70
Show file tree

Hide file tree

Showing 22 changed files with 37 additions and 7 deletions.
diff --git a/.htaccess b/.htaccess
@@ -36,7 +36,7 @@
 ############################################
 ## adjust memory limit
 
-    php_value memory_limit 768M
+    php_value memory_limit 2048M
     php_value max_execution_time 18000
 
 ############################################

diff --git a/app/code/Magento/Inventory/Controller/Adminhtml/Source/Edit.php b/app/code/Magento/Inventory/Controller/Adminhtml/Source/Edit.php
@@ -3,6 +3,8 @@
  * Copyright © Magento, Inc. All rights reserved.
  * See COPYING.txt for license details.
  */
+declare(strict_types=1);
+
 namespace Magento\Inventory\Controller\Adminhtml\Source;
 
 use Magento\Backend\App\Action;
@@ -48,7 +50,7 @@ public function execute()
     {
         $sourceId = $this->getRequest()->getParam(SourceInterface::SOURCE_ID);
         try {
-            $source = $this->sourceRepository->get($sourceId);
+            $source = $this->sourceRepository->get((int)$sourceId);
 
             /** @var Page $result */
             $result = $this->resultFactory->create(ResultFactory::TYPE_PAGE);

diff --git a/app/code/Magento/Inventory/Controller/Adminhtml/Source/InlineEdit.php b/app/code/Magento/Inventory/Controller/Adminhtml/Source/InlineEdit.php
@@ -63,7 +63,7 @@ public function execute()
             foreach ($requestData as $itemData) {
                 try {
                     $source = $this->sourceRepository->get(
-                        $itemData[SourceInterface::SOURCE_ID]
+                        (int)$itemData[SourceInterface::SOURCE_ID]
                     );
                     $this->dataObjectHelper->populateWithArray($source, $itemData, SourceInterface::class);
                     $this->sourceRepository->save($source);

diff --git a/app/code/Magento/Inventory/Controller/Adminhtml/Source/Save.php b/app/code/Magento/Inventory/Controller/Adminhtml/Source/Save.php
@@ -108,7 +108,7 @@ private function processSave(array $requestData, int $sourceId = null): int
             /** @var SourceInterface $source */
             $source = $this->sourceFactory->create();
         } else {
-            $source = $this->sourceRepository->get($sourceId);
+            $source = $this->sourceRepository->get((int)$sourceId);
         }
         $source = $this->sourceHydrator->hydrate($source, $requestData);
 

diff --git a/app/code/Magento/Inventory/Controller/Adminhtml/Stock/Edit.php b/app/code/Magento/Inventory/Controller/Adminhtml/Stock/Edit.php
@@ -48,7 +48,7 @@ public function execute()
     {
         $stockId = $this->getRequest()->getParam(StockInterface::STOCK_ID);
         try {
-            $stock = $this->stockRepository->get($stockId);
+            $stock = $this->stockRepository->get((int)$stockId);
 
             /** @var Page $result */
             $result = $this->resultFactory->create(ResultFactory::TYPE_PAGE);

diff --git a/app/code/Magento/Inventory/Controller/Adminhtml/Stock/InlineEdit.php b/app/code/Magento/Inventory/Controller/Adminhtml/Stock/InlineEdit.php
@@ -63,7 +63,7 @@ public function execute()
             foreach ($requestData as $itemData) {
                 try {
                     $stock = $this->stockRepository->get(
-                        $itemData[StockInterface::STOCK_ID]
+                        (int)$itemData[StockInterface::STOCK_ID]
                     );
                     $this->dataObjectHelper->populateWithArray($stock, $itemData, StockInterface::class);
                     $this->stockRepository->save($stock);

diff --git a/app/code/Magento/Inventory/Controller/Adminhtml/Stock/MassDelete.php b/app/code/Magento/Inventory/Controller/Adminhtml/Stock/MassDelete.php
@@ -59,7 +59,7 @@ public function execute()
         $deletedItemsCount = 0;
         foreach ($this->massActionFilter->getIds() as $id) {
             try {
-                $this->stockRepository->deleteById($id);
+                $this->stockRepository->deleteById((int) $id);
                 $deletedItemsCount++;
             } catch (CouldNotDeleteException $e) {
                 $errorMessage = __('[ID: %1] ', $id) . $e->getMessage();

diff --git a/app/code/Magento/InventoryApi/Api/AssignSourcesToStockInterface.php b/app/code/Magento/InventoryApi/Api/AssignSourcesToStockInterface.php
@@ -3,6 +3,8 @@
  * Copyright © Magento, Inc. All rights reserved.
  * See COPYING.txt for license details.
  */
+declare(strict_types=1);
+
 namespace Magento\InventoryApi\Api;
 
 /**

diff --git a/app/code/Magento/InventoryApi/Api/Data/SourceCarrierLinkInterface.php b/app/code/Magento/InventoryApi/Api/Data/SourceCarrierLinkInterface.php
@@ -3,6 +3,8 @@
  * Copyright © Magento, Inc. All rights reserved.
  * See COPYING.txt for license details.
  */
+declare(strict_types=1);
+
 namespace Magento\InventoryApi\Api\Data;
 
 use Magento\Framework\Api\ExtensibleDataInterface;

diff --git a/app/code/Magento/InventoryApi/Api/Data/SourceInterface.php b/app/code/Magento/InventoryApi/Api/Data/SourceInterface.php
@@ -3,6 +3,8 @@
  * Copyright © Magento, Inc. All rights reserved.
  * See COPYING.txt for license details.
  */
+declare(strict_types=1);
+
 namespace Magento\InventoryApi\Api\Data;
 
 use Magento\Framework\Api\ExtensibleDataInterface;

diff --git a/app/code/Magento/InventoryApi/Api/Data/SourceItemInterface.php b/app/code/Magento/InventoryApi/Api/Data/SourceItemInterface.php
@@ -3,6 +3,8 @@
  * Copyright © Magento, Inc. All rights reserved.
  * See COPYING.txt for license details.
  */
+declare(strict_types=1);
+
 namespace Magento\InventoryApi\Api\Data;
 
 use Magento\Framework\Api\ExtensibleDataInterface;

diff --git a/app/code/Magento/InventoryApi/Api/Data/SourceItemSearchResultsInterface.php b/app/code/Magento/InventoryApi/Api/Data/SourceItemSearchResultsInterface.php
@@ -3,6 +3,8 @@
  * Copyright © Magento, Inc. All rights reserved.
  * See COPYING.txt for license details.
  */
+declare(strict_types=1);
+
 namespace Magento\InventoryApi\Api\Data;
 
 use Magento\Framework\Api\SearchResultsInterface;

diff --git a/app/code/Magento/InventoryApi/Api/Data/SourceSearchResultsInterface.php b/app/code/Magento/InventoryApi/Api/Data/SourceSearchResultsInterface.php
@@ -3,6 +3,8 @@
  * Copyright © Magento, Inc. All rights reserved.
  * See COPYING.txt for license details.
  */
+declare(strict_types=1);
+
 namespace Magento\InventoryApi\Api\Data;
 
 use Magento\Framework\Api\SearchResultsInterface;

diff --git a/app/code/Magento/InventoryApi/Api/Data/StockInterface.php b/app/code/Magento/InventoryApi/Api/Data/StockInterface.php
@@ -3,6 +3,8 @@
  * Copyright © Magento, Inc. All rights reserved.
  * See COPYING.txt for license details.
  */
+declare(strict_types=1);
+
 namespace Magento\InventoryApi\Api\Data;
 
 use Magento\Framework\Api\ExtensibleDataInterface;

diff --git a/app/code/Magento/InventoryApi/Api/Data/StockSearchResultsInterface.php b/app/code/Magento/InventoryApi/Api/Data/StockSearchResultsInterface.php
@@ -3,6 +3,8 @@
  * Copyright © Magento, Inc. All rights reserved.
  * See COPYING.txt for license details.
  */
+declare(strict_types=1);
+
 namespace Magento\InventoryApi\Api\Data;
 
 use Magento\Framework\Api\SearchResultsInterface;

diff --git a/app/code/Magento/InventoryApi/Api/GetAssignedSourcesForStockInterface.php b/app/code/Magento/InventoryApi/Api/GetAssignedSourcesForStockInterface.php
@@ -3,6 +3,8 @@
  * Copyright © Magento, Inc. All rights reserved.
  * See COPYING.txt for license details.
  */
+declare(strict_types=1);
+
 namespace Magento\InventoryApi\Api;
 
 /**

diff --git a/app/code/Magento/InventoryApi/Api/SourceItemsSaveInterface.php b/app/code/Magento/InventoryApi/Api/SourceItemsSaveInterface.php
@@ -3,6 +3,8 @@
  * Copyright © Magento, Inc. All rights reserved.
  * See COPYING.txt for license details.
  */
+declare(strict_types=1);
+
 namespace Magento\InventoryApi\Api;
 
 /**

diff --git a/app/code/Magento/InventoryApi/Api/SourceRepositoryInterface.php b/app/code/Magento/InventoryApi/Api/SourceRepositoryInterface.php
@@ -3,6 +3,8 @@
  * Copyright © Magento, Inc. All rights reserved.
  * See COPYING.txt for license details.
  */
+declare(strict_types=1);
+
 namespace Magento\InventoryApi\Api;
 
 use Magento\Framework\Api\SearchCriteriaInterface;

diff --git a/app/code/Magento/InventoryApi/Api/StockRepositoryInterface.php b/app/code/Magento/InventoryApi/Api/StockRepositoryInterface.php
@@ -3,6 +3,8 @@
  * Copyright © Magento, Inc. All rights reserved.
  * See COPYING.txt for license details.
  */
+declare(strict_types=1);
+
 namespace Magento\InventoryApi\Api;
 
 use Magento\Framework\Api\SearchCriteriaInterface;

diff --git a/app/code/Magento/InventoryApi/Api/UnassignSourceFromStockInterface.php b/app/code/Magento/InventoryApi/Api/UnassignSourceFromStockInterface.php
@@ -3,6 +3,8 @@
  * Copyright © Magento, Inc. All rights reserved.
  * See COPYING.txt for license details.
  */
+declare(strict_types=1);
+
 namespace Magento\InventoryApi\Api;
 
 /**

diff --git a/app/code/Magento/InventoryCatalog/Api/DefaultSourceProviderInterface.php b/app/code/Magento/InventoryCatalog/Api/DefaultSourceProviderInterface.php
@@ -3,6 +3,7 @@
  * Copyright © Magento, Inc. All rights reserved.
  * See COPYING.txt for license details.
  */
+declare(strict_types=1);
 
 namespace Magento\InventoryCatalog\Api;
 

diff --git a/app/code/Magento/InventoryCatalog/Api/DefaultStockProviderInterface.php b/app/code/Magento/InventoryCatalog/Api/DefaultStockProviderInterface.php
@@ -3,6 +3,7 @@
  * Copyright © Magento, Inc. All rights reserved.
  * See COPYING.txt for license details.
  */
+declare(strict_types=1);
 
 namespace Magento\InventoryCatalog\Api;