Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Strict Typing for all PHP code added in the scope of MSI poject #99

Closed
maghamed opened this issue Sep 17, 2017 · 2 comments
Closed

Add Strict Typing for all PHP code added in the scope of MSI poject #99

maghamed opened this issue Sep 17, 2017 · 2 comments
Assignees
@DwayneH @chrom
Labels
Award: special achievement

Comments

@maghamed
Copy link
Contributor

Based on the Community Poll we've conducted
https://twitter.com/iminyaylo/status/905049975175962624

it makes sense to add declare(strict_types=1); for all PHP code in the scope of MSI
@naydav
Copy link

naydav commented Sep 28, 2017 •
edited
Loading

Also, need to add typecasting to Controllers and DataProviders

Example
https://github.com/magento-engcom/msi/blob/develop/app/code/Magento/Inventory/Controller/Adminhtml/Source/Edit.php#L51
In this case $sourceId is string

But expected type is integer
https://github.com/magento-engcom/msi/blob/develop/app/code/Magento/InventoryApi/Api/SourceRepositoryInterface.php#L51

After enabling Strict typing we will have got \TypeError
So need to add typecasting to all Controllers and DataProviders

chrom pushed a commit that referenced this issue Nov 3, 2017
#99 - Add Strict Typing
4571d70
chrom added a commit that referenced this issue Nov 10, 2017
@chrom
#99 - Add Strict Typing - add DataProviders
d72fca7
chrom added a commit that referenced this issue Nov 17, 2017
@chrom
#192 #99 - Add Strict Typing
253aeea
@maghamed maghamed mentioned this issue Nov 25, 2017
Merged
naydav pushed a commit that referenced this issue Dec 8, 2017
MSI: #99 - Add Strict Typing
f852ad6
naydav pushed a commit that referenced this issue Dec 8, 2017
MSI: #99 - Add Strict Typing
3f8a06e
naydav pushed a commit that referenced this issue Dec 8, 2017
MSI: #99 - Add Strict Typing
cd75aa9
naydav pushed a commit that referenced this issue Dec 8, 2017
Merge pull request #192 from magento-engcom/99_strict_typing
549f725 
#99 - Add Strict Typing
@naydav
Copy link

naydav commented Dec 8, 2017

#192

@naydav naydav closed this as completed Dec 8, 2017
okolesnyk pushed a commit that referenced this issue Mar 6, 2018
@magento-engcom-team
MAGETWO-88240: product images with same name overwrite previous image f…
a2119af 
…ix #99

 - Merge Pull Request magento-engcom/import-export-improvements#99 from umarch06/import-export-improvements:50-product-images-import-path-fix
 - Merged commits:
   1. 7803eed
   2. 0c6120e
   3. 768d1d7
okolesnyk pushed a commit that referenced this issue Mar 6, 2018
MAGETWO-88240: product images with same name overwrite previous image f…
cac6fb4 
…ix #99
@smoskaluk smoskaluk mentioned this issue Mar 23, 2018
Closed
magento-cicd2 pushed a commit that referenced this issue Mar 26, 2021
@dhorytskyi
Merge pull request #99 from magento-l3/1.2-bugfixes-031921
32e18bd 
[L3] Bugfixes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@DwayneH DwayneH

@chrom chrom

Labels
Award: special achievement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
6 participants
@naydav @DwayneH @chrom @maksek @maghamed @larsroettig