Refactoring: Code duplication EmailSender / ShipmentSender and so on

[amenk]

These classes do pretty much the same:
/app/code/Magento/Sales/Model/Order/Shipment/Sender/EmailSender.php

/app/code/Magento/Sales/Model/Order/Email/Sender/ShipmentSender.php

Should be refactored into one.
What is the reason we have two? Which one should be preferred?

Preconditions

Magento 2.4-develop

Steps to reproduce

1. Observe two classes.

app/code/Magento/Sales/Model/Order/Shipment/Sender/EmailSender.php
and
app/code/Magento/Sales/Model/Order/Email/Sender/ShipmentSender.php

Expected result

Should have different behaviors, or refactored into one.

Actual result

Two classes almost the same.

[engcom-backlog-nickolas]

Hello @amenk, thank you for your report.
We've acknowledged the issue and added to our backlog.

[korostii]

Ran into this, as well.
FYI it seems that for some reason the ../Shipment/Sender/EmailSender.php gets invoked when a shipment is created via API (so, both classes are used by Magento).
This can be a rather nasty surprise if you attempt to modify the corresponding behaviour using a di.xml plugin as you'll need to declare two plugins at once.

[rvoronovmeticulosity]

0b4d732
@dvoskoboinikov for what reasons the https://github.com/magento/magento2/blob/2.3-develop/app/code/Magento/Sales/Model/Order/Shipment/Sender/EmailSender.php was added considering that we already had https://github.com/magento/magento2/blob/2.3-develop/app/code/Magento/Sales/Model/Order/Email/Sender/ShipmentSender.php

[sivaschenko]

Hi @rvoronovmeticulosity https://github.com/magento/magento2/blob/2.3-develop/app/code/Magento/Sales/Model/Order/Shipment/Sender/EmailSender.php was introduced to work with data interfaces instead of the concrete model. So I believe https://github.com/magento/magento2/blob/2.3-develop/app/code/Magento/Sales/Model/Order/Email/Sender/ShipmentSender.php can be marked as deprecated and client code refactored to use the new service.

[m2-assistant]

Hi @engcom-Echo. Thank you for working on this issue.
In order to make sure that issue has enough information and ready for development, please read and check the following instruction: 👇

• 1. Verify that issue has all the required information. (Preconditions, Steps to reproduce, Expected result, Actual result).

  Details

  If the issue has a valid description, the label Issue: Format is valid will be added to the issue automatically. Please, edit issue description if needed, until label Issue: Format is valid appears.

• 2. Verify that issue has a meaningful description and provides enough information to reproduce the issue. If the report is valid, add Issue: Clear Description label to the issue by yourself.

• 3. Add Component: XXXXX label(s) to the ticket, indicating the components it may be related to.

• 4. Verify that the issue is reproducible on 2.4-develop branch

  Details

  - Add the comment @magento give me 2.4-develop instance to deploy test instance on Magento infrastructure.
  - If the issue is reproducible on 2.4-develop branch, please, add the label Reproduced on 2.4.x.
  - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!

• 5. Add label Issue: Confirmed once verification is complete.

• 6. Make sure that automatic system confirms that report has been added to the backlog.

[magento-engcom-team]

✅ Confirmed by @engcom-Echo
Thank you for verifying the issue. Based on the provided information internal tickets MC-30135 were created

Issue Available: @engcom-Echo, You will be automatically unassigned. Contributors/Maintainers can claim this issue to continue. To reclaim and continue work, reassign the ticket to yourself.

[m2-assistant]

Hi @drpayyne. Thank you for working on this issue.
Looks like this issue is already verified and confirmed. But if you want to validate it one more time, please, go though the following instruction:

• 1. Add/Edit Component: XXXXX label(s) to the ticket, indicating the components it may be related to.

• 2. Verify that the issue is reproducible on 2.4-develop branch

  Details

  - Add the comment @magento give me 2.4-develop instance to deploy test instance on Magento infrastructure.
  - If the issue is reproducible on 2.4-develop branch, please, add the label Reproduced on 2.4.x.
  - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!

• 3. If the issue is not relevant or is not reproducible any more, feel free to close it.

---

• Join Magento Community Engineering Slack and ask your questions in #github channel.

[vigneshbalasubramani]

#mm20in

[magento-engcom-team]

@vigneshbalasubramani thank you for joining. Please accept team invitation here and self-assign the issue.

[m2-assistant]

Hi @vigneshbalasubramani. Thank you for working on this issue.
Looks like this issue is already verified and confirmed. But if you want to validate it one more time, please, go though the following instruction:

• 1. Add/Edit Component: XXXXX label(s) to the ticket, indicating the components it may be related to.

• 2. Verify that the issue is reproducible on 2.4-develop branch

  Details

  - Add the comment @magento give me 2.4-develop instance to deploy test instance on Magento infrastructure.
  - If the issue is reproducible on 2.4-develop branch, please, add the label Reproduced on 2.4.x.
  - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!

• 3. If the issue is not relevant or is not reproducible any more, feel free to close it.

---

• Join Magento Community Engineering Slack and ask your questions in #github channel.

[magento-engcom-team]

Hi @amenk. Thank you for your report.
The issue has been fixed in #26714 by @drpayyne in 2.4-develop branch
Related commit(s):

• 4e1bfdeda9d7da91509a3f738e881ad92614a577
• 2f591a8805a03ca0479724a695baeb67586a2e59
• 5967ed459c507ca6f62829a52623ed4167e45409
• 997a0de132e38cc4bf4e0d94a9f65dbbc5b30bc5

The fix will be available with the upcoming 2.4.0 release.