Deprecated redundant class

[drpayyne]

Description

Deprecated redundant \Magento\Sales\Model\Order\Email\Sender\ShipmentSender with preference for \Magento\Sales\Model\Order\Shipment\Sender\EmailSender since it implements a data interface. Please refer #14885 (comment)

Fixed Issues

1. Refactoring: Code duplication EmailSender / ShipmentSender and so on #14885: Refactoring: Code duplication EmailSender / ShipmentSender and so on

Manual testing scenarios

1. No testing as this PR only deprecates a class

Contribution checklist

• Pull request has a meaningful description of its purpose
• All commits are accompanied by meaningful commit messages
• All new or changed code is covered with unit/integration tests (if applicable)
• All automated tests passed successfully (all builds are green)

[m2-assistant]

Hi @drpayyne. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

• @magento give me test instance - deploy test instance based on PR changes
• @magento give me 2.4-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Guide documentation.

[swnsma]

Hi @drpayyne,
Thank you for your contribution!
Could you please check failed static test?

[drpayyne]

Hey @swnsma, thanks for reviewing. I've fixed the static test failures. Thanks!

[magento-engcom-team]

Hi @swnsma, thank you for the review.
ENGCOM-6807 has been created to process this Pull Request
✳️ @swnsma, could you please add one of the following labels to the Pull Request?

Label	Description
Auto-Tests: Covered	All changes in Pull Request is covered by auto-tests
Auto-Tests: Not Covered	Changes in Pull Request requires coverage by auto-tests
Auto-Tests: Not Required	Changes in Pull Request does not require coverage by auto-tests

[swnsma]

Hi! Thank you, @drpayyne
May I ask you also ask you to mark as 'deprecated' all tests which is related to this class?

[drpayyne]

Hi @swnsma, fixed that too. Thanks!

[engcom-Alfa]

@swnsma Could you review the latest changes?
Thanks!

[swnsma]

Hi @drpayyne!
Thank you!
How about

\Magento\Sales\Model\Order\Email\Sender\ShipmentSenderTest
?

[drpayyne]

Hi @swnsma, sorry I don't understand your comment. I've deprecated the test class you've mentioned too. 🤔

[swnsma]

Hi @drpayyne!

You have deprecated class:

app/code/Magento/Sales/Test/Unit/Model/Order/Email/Sender/ShipmentSenderTest.php

But you did not deprecate integration tests class:

dev/tests/integration/testsuite/Magento/Sales/Model/Order/Email/Sender/ShipmentSenderTest.php

Or I miss something?

[drpayyne]

Hi @swnsma, I've deprecated that too now. Thank you.

[swnsma]

@drpayyne Thank you!

[swnsma]

@qa please make sure that tests works correctly with removed in this PR classes.

[magento-engcom-team]

Hi @swnsma, thank you for the review.
ENGCOM-6807 has been created to process this Pull Request
✳️ @swnsma, could you please add one of the following labels to the Pull Request?

Label	Description
Auto-Tests: Covered	All changes in Pull Request is covered by auto-tests
Auto-Tests: Not Covered	Changes in Pull Request requires coverage by auto-tests
Auto-Tests: Not Required	Changes in Pull Request does not require coverage by auto-tests

[engcom-Alfa]

✔️ QA Passed

[engcom-Charlie]

Failed functional test not related to the changes in this PR test fails in 2.4-develop with MSI modules.

[m2-assistant]

Hi @drpayyne, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.