Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

REST API Category translation #17186

Closed
magento2dev opened this issue Jul 27, 2018 · 21 comments
Closed

REST API Category translation #17186

magento2dev opened this issue Jul 27, 2018 · 21 comments
Labels
Component: Catalog Component: Webapi Use with concrete module component label E.g. "Component: Webapi" + "Catalog" Fixed in 2.4.x The issue has been fixed in 2.4-develop branch Issue: Clear Description Gate 2 Passed. Manual verification of the issue description passed Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed Issue: needs update Additional information is require, waiting for response Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development Priority: P3 May be fixed according to the position in the backlog. Progress: done Reproduced on 2.3.x The issue has been reproduced on latest 2.3 release Reproduced on 2.4.x The issue has been reproduced on latest 2.4-develop branch Severity: S3 Affects non-critical data or functionality and does not force users to employ a workaround. Triage: Dev.Experience Issue related to Developer Experience and needs help with Triage to Confirm or Reject it Triage: Ready for Triage Issue is ready to me triaged with Product Manager

Comments

@magento2dev
Copy link

magento2dev commented Jul 27, 2018

Additional information

test case steps description : #17186 (comment)

Preconditions

  1. Magento 2.2.3 & 2.3.x

Steps to reproduce

  1. Send REST PUT request to translate category name in specific store view : {{BaseURL}}rest/{{codeStoreView}}/V1/categories/{id}

{ "saveOptions": true, "category": { "id": 3, "name": "New Category Name Translated" } }

Expected result

  1. It should only update the category name field and create only one row in database for the specific store view

Actual result

  1. The request uncheck Enable Category, Include in Menu, Category Image, etc... attributes and create multiple rows in database for the specific store view
@magento-engcom-team magento-engcom-team added the Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed label Jul 27, 2018
@magento-engcom-team
Copy link
Contributor

Hi @anthony-jullien. Thank you for your report.
To help us process this issue please make sure that you provided the following information:

  • Summary of the issue
  • Information on your environment
  • Steps to reproduce
  • Expected and actual results

Please make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce. To deploy vanilla Magento instance on our environment, please, add a comment to the issue:

@magento-engcom-team give me {$VERSION} instance

where {$VERSION} is version tags (starting from 2.2.0+) or develop branches (2.2-develop +).
For more details, please, review the Magento Contributor Assistant documentation.

@anthony-jullien do you confirm that you was able to reproduce the issue on vanilla Magento instance following steps to reproduce?

  • yes
  • no

@ghost ghost self-assigned this Jul 27, 2018
@ghost ghost added Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development Issue: Clear Description Gate 2 Passed. Manual verification of the issue description passed Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Reproduced on 2.2.x The issue has been reproduced on latest 2.2 release Reproduced on 2.3.x The issue has been reproduced on latest 2.3 release Component: Webapi Use with concrete module component label E.g. "Component: Webapi" + "Catalog" labels Jul 27, 2018
@ghost ghost removed their assignment Jul 27, 2018
@ghost
Copy link

ghost commented Jul 27, 2018

@anthony-jullien, thank you for your report.
We've acknowledged the issue and added to our backlog.

@magento2dev
Copy link
Author

Thanks, do you have an official ticket to follow this important issue ? and do you know when a patch will be developed because we have the same issue on products.

Thanks !

@ghost
Copy link

ghost commented Jul 27, 2018

@anthony-jullien currently, we are not creating internal tickets, as we want to involve our community members in developing of Magento 2. Anyone can assign an issue on this tracker and submit pull-request with a proper fix.

@magento2dev
Copy link
Author

I don't understand a lot of people have this issue (#9186) and nobody is finding a solution for this major issue, you can't create an internal ticket for helping the community ?

@hostep
Copy link
Contributor

hostep commented Jul 29, 2018

Update: ignore this post, this isn't fixing the reported issue

Hi @anthony-jullien: we've recently received a patch from the Magento Cloud support with a fix for this issue. Unfortunately I haven't found the time yet to test it and I can't post the patch here, since it contains code used in certain modules of the Magento Enterprise Edition.

But, I can see that Magento already committed parts of the patch we received here on github, it just hasn't been released yet in a release.
Here are the commits I can find which seem to reflect the same changes as I can find in the patch they send us:

  • MAGETWO-87589: [Magento Cloud] - Issue with polluted database when updating product attributes through API: 0383b22
  • MAGETWO-73638: Product "Use Default Value" checkbox for an attributes are unchecked for the new website scope: a001993 & c30b295
  • MAGETWO-90768: 'Use Default Value' checkboxes in Design section of a category are not checked by default: 6949623

Maybe you can first test on a new installation cloned from github from the latest 2.2-develop branch and see if the issue has been resolved. And if that is the case, then try to create a patch with the above commits, and attempt to get it working that way on your current version. Hopefully I didn't miss any commits in my list above...

Hope this helps!

@magento2dev
Copy link
Author

magento2dev commented Jul 29, 2018

Hi @hostep,

Thanks a lot for your reply !
Sadly these tickets refers to the product issue, I'm trying to solve the same issue on the category edit page. It would be great if you could post the patch here after removing the Magento Enterprise Edition part.

Thanks for your help !

@hostep
Copy link
Contributor

hostep commented Jul 29, 2018

Update: ignore this post, this isn't fixing the reported issue

Indeed, it's for products, but some of the code also applies to categories, so who knows ...

Anyway, here is the patch we got, stripped out the changes from the RMA module (EE only), was created for Magento 2.2.2, and I've not tested it yet, hope this helps.

MDVA-8506_EE_2.2.2_v2_COMPOSER.txt

@magento2dev
Copy link
Author

Thanks a lot @hostep for your responsiveness, I tried this afternoon the fourth commit you mentioned above and sadly none of them is fixing this issue, it does not fixing the issue concerning the product store duplication (when you set a product available in a new website all use default value checkboxes are unchecked at store level).

I just tried your patch but it's the same as a001993, it does not solve the issue. I don't understand why Magento (@magento-engcom-team) does not provide any fix, it's a major issue, we lost all the advantages of the Magento store view.

Thanks for your help !

@hostep
Copy link
Contributor

hostep commented Jul 29, 2018

Hi @anthony-jullien: I did a little testing on the latest 2.2-develop branch this time and indeed, the API part is not fixed, even not for products.
The only thing which seems to be fixed by the above commits, is the fact that the Use Default Value checkboxes stay checked and don't cause extra rows being inserted in the database when saving a category/product on a storeview level when you leave all accordions closed in the backend of Magento.
So these ones are probably fixed in 2.2-develop: #13665 & #9486, but the issue you reported (same as #9186) is not fixed.

Great, I explicitly asked the Cloud support if the API part was fixed by that patch, since by just reading the code, I couldn't see much changed in the code related to the API and they kept confirming it was fixed. But yeah, I should have actually tried testing myself earlier. I wonder why we (=our client) wants to keep paying for the enterprise support when they act like that...

@magento2dev
Copy link
Author

magento2dev commented Jul 29, 2018

Thanks for your help ! @hostep
Yes the patch solve the product issue but I don't think we have this one on Magento 2.2.3. I report my issue because they keep closing this issue even if it's not fixed (like #9186)...

Exactly I don't understand why they keep saying it's fixed as it's definitely not... I totally agree it's becoming very difficult to use to community edition. I'm working with a lot of Magento developers and many are thinking to migrate to another CMS, there are too many bugs in Magento 2.2 (more than one year after it's released) and @magento-engcom-team don't even take the time to fix the major issues...

@kolonuk
Copy link

kolonuk commented Sep 13, 2018

@kolonuk - monitoring

@vasilii-b vasilii-b self-assigned this Nov 14, 2018
@magento-engcom-team
Copy link
Contributor

magento-engcom-team commented Nov 14, 2018

Hi @vasilii-b. Thank you for working on this issue.
Looks like this issue is already verified and confirmed. But if your want to validate it one more time, please, go though the following instruction:

  • 1. Add/Edit Component: XXXXX label(s) to the ticket, indicating the components it may be related to.

  • 2. Verify that the issue is reproducible on 2.3-develop branch

    Details- Add the comment @magento-engcom-team give me 2.3-develop instance to deploy test instance on Magento infrastructure.
    - If the issue is reproducible on 2.3-develop branch, please, add the label Reproduced on 2.3.x.
    - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!

  • 3. Verify that the issue is reproducible on 2.2-develop branch.

    Details- Add the comment @magento-engcom-team give me 2.2-develop instance to deploy test instance on Magento infrastructure.
    - If the issue is reproducible on 2.2-develop branch, please add the label Reproduced on 2.2.x

  • 4. If the issue is not relevant or is not reproducible any more, feel free to close it.

@ghost ghost unassigned lbajsarowicz Apr 18, 2020
@ghost ghost added Progress: ready for dev and removed Progress: PR Created Indicates that Pull Request has been created to fix issue Progress: PR in progress labels Apr 18, 2020
@engcom-Alfa engcom-Alfa added Reproduced on 2.4.x The issue has been reproduced on latest 2.4-develop branch Triage: Ready for Triage Issue is ready to me triaged with Product Manager labels Jul 16, 2020
@sdzhepa sdzhepa added the Triage: Dev.Experience Issue related to Developer Experience and needs help with Triage to Confirm or Reject it label Sep 23, 2020
@gabrieldagama gabrieldagama added Priority: P3 May be fixed according to the position in the backlog. Severity: S3 Affects non-critical data or functionality and does not force users to employ a workaround. labels Sep 29, 2020
@sdzhepa
Copy link
Contributor

sdzhepa commented Oct 23, 2020

@magento2dev @hostep

The related/duplicate issue has been fixed and delivered #30047 (comment)

It seems we can close this issue as already fixed, but i would like to ask you for confirmation

@sdzhepa sdzhepa added the Issue: needs update Additional information is require, waiting for response label Oct 23, 2020
@stale
Copy link

stale bot commented Jan 7, 2021

This issue has been automatically marked as stale because it has not had recent activity. It will be closed after 14 days if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale issue label Jan 7, 2021
@hostep
Copy link
Contributor

hostep commented Jan 7, 2021

@sdzhepa: sorry for delay but I no longer have personal interest in this bug or its fix. Maybe somebody else can confirm if it's fixed or not?

@stale stale bot removed the stale issue label Jan 7, 2021
@sdzhepa
Copy link
Contributor

sdzhepa commented Feb 5, 2021

The issue has been fixed in #17186 (comment)

@sdzhepa sdzhepa closed this as completed Feb 5, 2021
@sdzhepa sdzhepa added Fixed in 2.4.x The issue has been fixed in 2.4-develop branch and removed Progress: done labels Feb 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: Catalog Component: Webapi Use with concrete module component label E.g. "Component: Webapi" + "Catalog" Fixed in 2.4.x The issue has been fixed in 2.4-develop branch Issue: Clear Description Gate 2 Passed. Manual verification of the issue description passed Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed Issue: needs update Additional information is require, waiting for response Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development Priority: P3 May be fixed according to the position in the backlog. Progress: done Reproduced on 2.3.x The issue has been reproduced on latest 2.3 release Reproduced on 2.4.x The issue has been reproduced on latest 2.4-develop branch Severity: S3 Affects non-critical data or functionality and does not force users to employ a workaround. Triage: Dev.Experience Issue related to Developer Experience and needs help with Triage to Confirm or Reject it Triage: Ready for Triage Issue is ready to me triaged with Product Manager
Projects
Development

Successfully merging a pull request may close this issue.