Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: FIX #8897: "Use default" mechanism for Admin GUI and APIs #27035

Closed

Conversation

lbajsarowicz
Copy link
Contributor

@lbajsarowicz lbajsarowicz commented Feb 26, 2020

Description (*)

  1. Address the issue
  2. Cover with tests (Integration and API Functional)
  3. Fix the issue

Related Pull Requests

Fixed Issues (if relevant)

  1. Saving product with non-default store scope causes untouched attributes to become store scoped if loaded using ProductRepository #8897
  2. REST API : Save Product Detail per store view not working  #4952
  3. REST API catalogProductRepositoryV1 overwriting default values #9186
  4. Updating a product through the API unchecks "Use Default Value" on a bunch of attributes #26484
  5. REST API Category translation #17186

Manual testing scenarios (*)

TBD

Questions or comments

Side effects:

  1. Reduced EAV tables size, due to the removal of duplicated data.

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds are green)

Support

Solving this issue is supported by Mediotype

@m2-assistant
Copy link

m2-assistant bot commented Feb 26, 2020

Hi @lbajsarowicz. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.4-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Guide documentation.

@hostep
Copy link
Contributor

hostep commented Feb 26, 2020

Thanks for working on this @lbajsarowicz!

Is this going to fix #9186 & #26484 as well? (those are duplicates btw, there are probably a lot more tickets in github mentioning the same issue)
Also: #17186 (for categories)

@lbajsarowicz
Copy link
Contributor Author

@hostep Yes, my changes are going to fix most of these.

@lbajsarowicz
Copy link
Contributor Author

@magento run all tests

I have no idea why it hasn't started o.O

@lbajsarowicz
Copy link
Contributor Author

I've extracted url_key / url_path part from this PR to separate one #27291

@lbajsarowicz lbajsarowicz changed the title [WIP] FIX #8897: "Use default" mechanism for Admin GUI and APIs WIP: FIX #8897: "Use default" mechanism for Admin GUI and APIs Mar 18, 2020
@lbajsarowicz
Copy link
Contributor Author

I'm really sorry to disappoint you, as - due to limited time - I was unable to fix that before 2.4 feature freeze. I'm going to fix that before 2.5

@m2-assistant
Copy link

m2-assistant bot commented Apr 18, 2020

Hi @lbajsarowicz, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment