Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Export Coupon Code Grid redirect to DashBoard when create New Cart Price Rule #24468

Closed
edenduong opened this issue Sep 5, 2019 · 16 comments · Fixed by #24471
Closed

Export Coupon Code Grid redirect to DashBoard when create New Cart Price Rule #24468

edenduong opened this issue Sep 5, 2019 · 16 comments · Fixed by #24471
Assignees
@edenduong
Labels
Component: Admin Component: Rule Event: mm19pl Fixed in 2.4.x The issue has been fixed in 2.4-develop branch Issue: Clear Description Gate 2 Passed. Manual verification of the issue description passed Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development Reproduced on 2.3.x The issue has been reproduced on latest 2.3 release

Comments

@edenduong
Copy link
Contributor

Coupon Grid in create new "Cart Price Rule" should be disabled. Because it is useless and when exporting, it has the error:

Preconditions (*)

  1. Magento 2.3-develop

Steps to reproduce (*)

  1. Go to backend
  2. Marketing-> Cart Price Rules, Create New Cart Price Rule
  3. In " Coupon" choose Specific Coupon
  4. Check "Use Auto Generation"
  5. Scroll to Manage Coupon Codes
  6. Export

Expected result (*)

  1. I think Should be disable the Grid, because in the New Cart Price Rule, there is No Coupon Code what is generated

Actual result (*)

  1. Redirect to dashboard

image
@m2-assistant
Copy link

m2-assistant bot commented Sep 5, 2019

Hi @edenduong. Thank you for your report.
To help us process this issue please make sure that you provided the following information:

  • Summary of the issue
  • Information on your environment
  • Steps to reproduce
  • Expected and actual results

Please make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce. To deploy vanilla Magento instance on our environment, please, add a comment to the issue:

@magento give me 2.3-develop instance - upcoming 2.3.x release

For more details, please, review the Magento Contributor Assistant documentation.

@edenduong do you confirm that you were able to reproduce the issue on vanilla Magento instance following steps to reproduce?

  • yes
  • no

@magento-engcom-team magento-engcom-team added the Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed label Sep 5, 2019
@engcom-Bravo engcom-Bravo self-assigned this Sep 5, 2019
@m2-assistant
Copy link

m2-assistant bot commented Sep 5, 2019

Hi @engcom-Bravo. Thank you for working on this issue.
In order to make sure that issue has enough information and ready for development, please read and check the following instruction: 👇

  • 1. Verify that issue has all the required information. (Preconditions, Steps to reproduce, Expected result, Actual result).

    DetailsIf the issue has a valid description, the label Issue: Format is valid will be added to the issue automatically. Please, edit issue description if needed, until label Issue: Format is valid appears.

  • 2. Verify that issue has a meaningful description and provides enough information to reproduce the issue. If the report is valid, add Issue: Clear Description label to the issue by yourself.

  • 3. Add Component: XXXXX label(s) to the ticket, indicating the components it may be related to.

  • 4. Verify that the issue is reproducible on 2.3-develop branch

    Details- Add the comment @magento give me 2.3-develop instance to deploy test instance on Magento infrastructure.
    - If the issue is reproducible on 2.3-develop branch, please, add the label Reproduced on 2.3.x.
    - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!

  • 5. Add label Issue: Confirmed once verification is complete.

  • 6. Make sure that automatic system confirms that report has been added to the backlog.

@edenduong edenduong mentioned this issue Sep 5, 2019
Merged
4 tasks
@ghost ghost assigned edenduong Sep 5, 2019
@ajijshekh123 ajijshekh123 self-assigned this Sep 6, 2019
@m2-assistant
Copy link

m2-assistant bot commented Sep 6, 2019 •
edited by ajijshekh123
Loading

Hi @ajijshekh123. Thank you for working on this issue.
In order to make sure that issue has enough information and ready for development, please read and check the following instruction: 👇

  • 1. Verify that issue has all the required information. (Preconditions, Steps to reproduce, Expected result, Actual result).

    DetailsIf the issue has a valid description, the label Issue: Format is valid will be added to the issue automatically. Please, edit issue description if needed, until label Issue: Format is valid appears.

  • 2. Verify that issue has a meaningful description and provides enough information to reproduce the issue. If the report is valid, add Issue: Clear Description label to the issue by yourself.

  • 3. Add Component: XXXXX label(s) to the ticket, indicating the components it may be related to.

  • 4. Verify that the issue is reproducible on 2.3-develop branch

    Details- Add the comment @magento give me 2.3-develop instance to deploy test instance on Magento infrastructure.
    - If the issue is reproducible on 2.3-develop branch, please, add the label Reproduced on 2.3.x.
    - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!

  • 5. Add label Issue: Confirmed once verification is complete.

  • 6. Make sure that automatic system confirms that report has been added to the backlog.

@ajijshekh123 ajijshekh123 added Component: Admin Issue: Clear Description Gate 2 Passed. Manual verification of the issue description passed Component: Rule labels Sep 6, 2019
@ajijshekh123
Copy link

Give me @magento give me 2.3-develop instance

@magento-engcom-team
Copy link
Contributor

Hi @ajijshekh123. Thank you for your request. I'm working on Magento 2.3-develop instance for you

@magento-engcom-team
Copy link
Contributor

Hi @ajijshekh123, here is your Magento instance.
Admin access: https://i-24468-2-3-develop.instances.magento-community.engineering/admin
Login: admin Password: 123123q
Instance will be terminated in up to 3 hours.

@ajijshekh123
Copy link

@edenduong - I have verified this issue in Magento 2.3 Instance. Please see attached the video:
Magento Issue

Please let me know if any issue missing in my side. Currently, I don't have to reproduce this issue.

@ajijshekh123 ajijshekh123 added Issue: Cannot Reproduce Cannot reproduce the issue on the latest `2.4-develop` branch Progress: needs update labels Sep 6, 2019
@edenduong
Copy link
Contributor Author

@ajijshekh123 : Please Check "Use Auto Generation" -> after that, Scroll to Manage Coupon Codes , Export the Coupon Grid

@ajijshekh123
Copy link

@edenduong - It displays the '404 Error', Functionality should be working as expected result.
See screenshot:
2019-09-06

@ajijshekh123 ajijshekh123 added Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Reproduced on 2.3.x The issue has been reproduced on latest 2.3 release and removed Issue: Cannot Reproduce Cannot reproduce the issue on the latest `2.4-develop` branch Progress: needs update labels Sep 6, 2019
@ghost ghost unassigned ajijshekh123 Sep 6, 2019
@magento-engcom-team
Copy link
Contributor

✅ Confirmed by @ajijshekh123
Thank you for verifying the issue. Based on the provided information internal tickets MC-19907 were created

Issue Available: @ajijshekh123, You will be automatically unassigned. Contributors/Maintainers can claim this issue to continue. To reclaim and continue work, reassign the ticket to yourself.

@magento-engcom-team magento-engcom-team added the Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development label Sep 6, 2019
@edenduong
Copy link
Contributor Author

@ajijshekh123: Yes. Because in this Magento instance, it disable the form key, so 404 error. If the form key is enabled , the error "Redirect to the dashboard" will happen.

@engcom-Bravo engcom-Bravo added Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed and removed Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed labels Sep 6, 2019
@ghost ghost unassigned engcom-Bravo Sep 6, 2019
@magento-engcom-team
Copy link
Contributor

✅ Confirmed by @engcom-Bravo
Thank you for verifying the issue. Based on the provided information internal tickets MC-19907 were created

Issue Available: @engcom-Bravo, You will be automatically unassigned. Contributors/Maintainers can claim this issue to continue. To reclaim and continue work, reassign the ticket to yourself.

@soniaandrianow
Copy link

#mm19pl

@magento-engcom-team
Copy link
Contributor

@soniaandrianow thank you for joining. Please accept team invitation here and self-assign the issue.

@soniaandrianow soniaandrianow self-assigned this Sep 15, 2019
@m2-assistant
Copy link

m2-assistant bot commented Sep 15, 2019

Hi @soniaandrianow. Thank you for working on this issue.
Looks like this issue is already verified and confirmed. But if you want to validate it one more time, please, go though the following instruction:

  • 1. Add/Edit Component: XXXXX label(s) to the ticket, indicating the components it may be related to.

  • 2. Verify that the issue is reproducible on 2.3-develop branch

    Details- Add the comment @magento give me 2.3-develop instance to deploy test instance on Magento infrastructure.
    - If the issue is reproducible on 2.3-develop branch, please, add the label Reproduced on 2.3.x.
    - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!

  • 3. If the issue is not relevant or is not reproducible any more, feel free to close it.

soniaandrianow pushed a commit to soniaandrianow/magento2 that referenced this issue Sep 15, 2019
magento#24468: Export Coupon Code Grid redirect to DashBoard when cre…
587f6e1 
…ate New Cart Price Rule

Fixed redirect -> not to dashboard but to edit page
Export disabled if rule is new (has no id)
@soniaandrianow soniaandrianow mentioned this issue Sep 15, 2019
Closed
4 tasks
soniaandrianow pushed a commit to soniaandrianow/magento2 that referenced this issue Sep 15, 2019
magento#24468: Export Coupon Code Grid redirect to DashBoard when cre…
60b75ab 
…ate New Cart Price Rule

null check for rule
soniaandrianow pushed a commit to soniaandrianow/magento2 that referenced this issue Sep 15, 2019
magento#24468: Export Coupon Code Grid redirect to DashBoard when cre…
c8c2b43 
…ate New Cart Price Rule

cs fix
@ghost ghost unassigned soniaandrianow Sep 15, 2019
@VladimirZaets VladimirZaets added the Fixed in 2.4.x The issue has been fixed in 2.4-develop branch label Jan 8, 2020
@VladimirZaets
Copy link
Contributor

Hi @edenduong. Thank you for your report.
The issue has been fixed in #24471 by @edenduong in 2.4-develop branch
Related commit(s):

The fix will be available with the upcoming 2.4.0 release.

@sdzhepa sdzhepa mentioned this issue May 9, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@edenduong edenduong

Labels
Component: Admin Component: Rule Event: mm19pl Fixed in 2.4.x The issue has been fixed in 2.4-develop branch Issue: Clear Description Gate 2 Passed. Manual verification of the issue description passed Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development Reproduced on 2.3.x The issue has been reproduced on latest 2.3 release
Projects
None yet
Milestone
No milestone
6 participants
@VladimirZaets @edenduong @soniaandrianow @ajijshekh123 @magento-engcom-team @engcom-Bravo