Resolve Export Coupon Code Grid redirect to DashBoard when create New Cart Price Rule issue24468

[edenduong]

Description (*)

Coupon Grid in create new "Cart Price Rule" should be disabled. Because it is useless and when exporting, it has the error

Solution: Hide the grid when create new

1. Resolve Export Coupon Code Grid redirect to DashBoard when create New Cart Price Rule #24468: Export Coupon Code Grid redirect to DashBoard when create New Cart Price Rule

Fixed Issues (if relevant)

1. Export Coupon Code Grid redirect to DashBoard when create New Cart Price Rule #24468: Export Coupon Code Grid redirect to DashBoard when create New Cart Price Rule

Manual testing scenarios (*)

1. Go to backend
2. Marketing-> Cart Price Rules, Create New Cart Price Rule
3. In " Coupon" choose Specific Coupon
4. Check "Use Auto Generation"
5. Scroll to Manage Coupon Codes
6. Export

Expected result (*)

1. Should export empty file

Questions or comments

Contribution checklist (*)

• Pull request has a meaningful description of its purpose
• All commits are accompanied by meaningful commit messages
• All new or changed code is covered with unit/integration tests (if applicable)
• All automated tests passed successfully (all builds are green)

[m2-assistant]

Hi @edenduong. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

• @magento give me test instance - deploy test instance based on PR changes
• @magento give me 2.3-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Guide documentation.

[edenduong]

No introduce the Public function, because it already in the Parent Class

[magento-engcom-team]

Hi @dmytro-ch, thank you for the review.
ENGCOM-5822 has been created to process this Pull Request
✳️ @dmytro-ch, could you please add one of the following labels to the Pull Request?

Label	Description
Auto-Tests: Covered	All changes in Pull Request is covered by auto-tests
Auto-Tests: Not Covered	Changes in Pull Request requires coverage by auto-tests
Auto-Tests: Not Required	Changes in Pull Request does not require coverage by auto-tests

[engcom-Alfa]

Hi @edenduong ,

During testing we faced with the issue.

Problem: JS error message occurs when we click on "Generate" button

Steps to reproduce:

1. Login to Admin;
2. Go to Marketing->Cart Price Rules->Add New Rule;
3. Fill all required fields;
4. Select "Specific Coupon" from "Coupon" drop-down menu;
5. Mark ✔️ "Use Auto Generation" checkbox;
6. Go to "Manage Coupon Codes " tab;
7. Fill "Coupon Qty" field and click on "Generate" button;

Actual Result: JS error message occurs

@edenduong Could you take a look, please?

Thanks!

[edenduong]

@magento give me test instance

[magento-engcom-team]

Hi @edenduong. Thank you for your request. I'm working on Magento instance for you

[magento-engcom-team]

Hi @edenduong, here is your new Magento instance.
Admin access: https://pr-24471.instances.magento-community.engineering/admin
Login: admin Password: 123123q

[edenduong]

Hi @engcom-Alfa, @dmytro-ch : I fixed it. Please check it again.

[edenduong]

Hi @VladimirZaets : I have changed the source code. I fixed Export button functionality to handle cases when the grid is empty instead of hide the grid.

[slavvka]

@magento give me test instance

[magento-engcom-team]

Hi @slavvka. Thank you for your request. I'm working on Magento instance for you

[magento-engcom-team]

Hi @slavvka, here is your new Magento instance.
Admin access: https://pr-24471.instances.magento-community.engineering/admin
Login: admin Password: 123123q

[magento-engcom-team]

Hi @dmytro-ch, thank you for the review.
ENGCOM-5822 has been created to process this Pull Request

[magento-engcom-team]

Hi @slavvka, thank you for the review.
ENGCOM-5822 has been created to process this Pull Request

[engcom-Alfa]

✔️ QA Passed

[m2-assistant]

Hi @edenduong, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.