[2.1.0] Problem on mobile when catalog gallery allowfullscreen is false

[peec]

This is repost of #2818 since that one got closed due to incorrect bug report guidelines. I have the same issue.

Preconditions

1. Magento 2.1.0 GA
2. PHP 7.0.3
3. MySQL 5.6
4. Linux Mint
5. Tested in browser: Chrome latest ( mobile view )

Steps to reproduce

1. In theme's view.xml, set gallery's allowfullscreen variable to false.
2. Flush cache and static files.
3. Go to a product page with an image on a mobile touch capable device, or minimize the screen to mobile view in chrome. Tap on the image.

Expected result

1. Nothing should happen when image is clicked since "allowfullscreen" is false.

Actual result

A white page ( the page-wrapper is hidden ).

I found that in lib/mage/gallery/gallery.js, even when allowfullscreen = false may be preventing the popup, code is still being executed that hides the page-wrapper.

if (this.isTouchEnabled) {
    this.settings.$element.on('tap', '.fotorama__stage__frame', function () {
        var translate = getTranslate($(this).parents('.fotorama__stage__shaft'));

        if (translate[1] === '0' && !$(this).hasClass('fotorama-video-container')) {
            self.openFullScreen();
            self.settings.$pageWrapper.hide();
        }
    });
}

Best case would probably be to check allowfullscreen prior to self.settings.$pageWrapper.hide();

[ghost]

This is the second bug that I have noticed that impacts customer experience on mobile. If you inadvertently tap the product image while attempting to scroll you basically render your site inaccessible until you refresh the page. @ilol any updates on this. TY

[ilol]

We have fixed #5302 (internal MAGETWO-55608 )
We will reproduce your present issue and then will fix it if it is reproducible.

[ilol]

@Hyroniemus can you please share the link to your site. In PM if you want. Thanks

[ilol]

@peec , can you please share the link to your site (if it is live). In PM if you want. Thanks

[ghost]

Unable to send private messages, what about the email in your profile?

[ilol]

It works!

[LucScu]

anyone fixed this bug?

[ilol]

The bug is fixed. Wait for mainline appearance

[LucScu]

@ilol could you post the code to fix this bug like you done here 7597a52?

[ilol]

Sorry, mistake. The issue is nor fixed yes. This is tracking number: MAGETWO-59075

[LucScu]

@ilol thx for update.
How could i visit your link? It seems that i can't access to it.

[ilol]

That is our internal system, I can`t grant access to you

[LucScu]

yes i understand, hope you fix this early, thx

[ghost]

@ilol will a fix for this be present in the next release?

[ilol]

We can`t reproduce it

[ghost]

Using an android device this bug is still present. I haven't been able to test on other mobile devices.

[ilol]

Will test with Android.
Please clarify Android version and device

[ghost]

Android 5.1
Chrome 53.0.2785.124

[ziiljuks]

Same happens for me but on desktop view (laptop with touchscreen if that somehow changes things).
Ubuntu 16.04. Clean M 2.1.2 install. Luma theme, developer mode, cache disabled.

With mouse clicks and touch.

[ghost]

@ilol any update on this?

[yofisim]

Any news about this? This is a huge bug for UX.

[Tristan-N]

@ilol Is there any update/news on this issue? I have Fotorama issues as well for mobile users and would like to see it solved. I mean, it should be possible to figure something out in 4 months, right?

[jpgreth]

Same Problem here. Costumer isn't very happy about this behaviour...

[ghost]

Give magic zoom a try. It's a paid extension, but it works well. Fotorama has issues on mobile.

[Tristan-N]

@jupiter01 I totally agree. We use it since a couple of weeks now and it's really great. @magento-team, maybe you should consider this instead of Fotorama?

[Crossmotion]

Bug still exists in Magento 2.1.3. Solution to fix this:

in lib/web/mage/gallery/gallery.js
replace if (this.isTouchEnabled) { to if (this.isTouchEnabled && this.settings.isFullscreen) {

This prevents the fullscreen view to open when fullscreen is disabled.

[Crossmotion]

Suggested fix in pull request here: #8434

[vrann]

@Crossmotion @peec #8434 is accepted, can the issue be closed?

[Crossmotion]

@vrann, Fine for me. Thanks for processing the fix so fas!

[underser]

Hi!
Can enybody, please, explain me. How I can override initialize method (for add fix from @Crossmotion), that was defined in this file lib/web/mage/gallery/gallery.js. I try write mixin, but can't get this method in it.
All that I was found is this https://magento.stackexchange.com/questions/104324/how-to-extend-core-js-files-or-class-or-function-in-magento2

Thank you very much.

[magento-team]

Internal ticket to track issue progress: MAGETWO-64250

[magento-engcom-team]

Hi @peec. Thank you for your report.
The issue has been fixed in #14098 by @simpleadm in 2.1-develop branch
Related commit(s):

• ab695e07f14d2176f815371e5cadd33469815923

The fix will be available with the upcoming 2.1.14 release.