Problem on mobile when catalog gallery allowfullscreen is false #5808 #8434
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
@Crossmotion thank you for the contribution. I will let you know on any additional questions after verification. |
|
LGTM 👍 |
|
@zetlen we've been trying to reproduce the issue and it is not reproducible on 2.1.3 or 2.1-dev. Android emulated device was used to test it. Can you provide more details on environment when the bug is reproduced? I.e. device, browser, etc. |
|
@Crossmotion sorry, wrong name reference in comment earlier :) please take a look. |
|
@Crossmotion please share any information available so that issue can be reproduced. |
|
@Crossmotion reproduced the issue on iPhone. Testing fix. |
mmansoor-magento
pushed a commit
that referenced
this pull request
Feb 18, 2017
…when catalog gallery allowfullscreen is false #5808
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#5808