Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"none" shown as label for short description #9161

Closed
MrDaar opened this issue Apr 7, 2017 · 3 comments
Closed

"none" shown as label for short description #9161

MrDaar opened this issue Apr 7, 2017 · 3 comments
Labels
bug report duplicate Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed

Comments

@MrDaar
Copy link

MrDaar commented Apr 7, 2017

Preconditions

  1. Magento: 2.1.5
  2. PHP: 7

Steps to reproduce

  1. View a product on the frontend.
  2. If you have a translation for "none", your translation will show above the text.
  3. i.e.:
<none in your language>
<short description>
ingen
This product is great!

Expected result

  1. No attribute label if the label is "none"

Actual result

  1. Label "none" (in your language) is shown.

Possible solution:
vendor/magento/module-catalog/view/frontend/templates/product/view/attribute.phtml line:37

<?php if ($_attributeLabel != 'none'): ?>

becomes

<?php if ($_attributeLabel != __('none')): ?>
@mattias
Copy link

mattias commented Jun 7, 2017

We still have this even in 2.1.7 and have been waiting for a fix.

Right now we have decided to just not translate "none" until this is fixed.

@kweij
Copy link
Contributor

kweij commented Jul 12, 2017

@orlangur
Copy link
Contributor

Closing in favor of #10738 (it is the newest one but with G2 Passed label).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug report duplicate Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed
Projects
None yet
Development

No branches or pull requests

5 participants