Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix for translated attribute label comparisson. #10739

Merged
merged 1 commit into from
Sep 4, 2017
Merged

Fix for translated attribute label comparisson. #10739

merged 1 commit into from
Sep 4, 2017

Conversation

nowszy
Copy link
Contributor

@nowszy nowszy commented Sep 1, 2017 •
edited by miguelbalparda
Loading

Preconditions

  1. Clean instance of Magento 2.1.8
  2. Store displayed in some foreign languege i.e. pl_PL
  3. Simple product with some attribute visible on product page.

Steps to reproduce

  1. Go to product page.
  2. See attribute label ('none' translated to your foreign language) in the attributes section/

Expected result

  1. 'none' label translated to other languages i.e. polish lang - 'brak' should not be displayed
  2. comparisson in line 37 of app/code/Magento/Catalog/view/frontend/templates/product/view/attribute.phtml is changed to if ($_attributeLabel != __('none')) in order to not display 'none' translated to foreign language

Actual result

  1. In the template app/code/Magento/Catalog/view/frontend/templates/product/view/attribute.phtml line 37 you have followin comparisson: if ($_attributeLabel != 'none') but at this part of code $_attributeLabel is already translated.

@nowszy
magento#10738
093e742 
Fix for translated attribute label comparisson. Refs magento#10738
@magento-cicd2
Copy link
Contributor

magento-cicd2 commented Sep 1, 2017 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@nowszy nowszy changed the title Fix for translated attribute label comparisson. Refs #10738 Fix for translated attribute label comparisson. Sep 1, 2017
@ishakhsuvarov ishakhsuvarov added this to the September 2017 milestone Sep 1, 2017
@miguelbalparda miguelbalparda self-assigned this Sep 1, 2017
@miguelbalparda
Copy link
Contributor

I'm processing this as we speak @nowszy, thank you for your contribution!

@magento-team magento-team merged commit 093e742 into magento:develop Sep 4, 2017
magento-team pushed a commit that referenced this pull request Sep 4, 2017
@ishakhsuvarov
MAGETWO-72226: Fix for translated attribute label comparisson. #10739
c20b2e9
@nowszy nowszy deleted the magento2-10738 branch September 5, 2017 07:48
@korostii
Copy link
Contributor

korostii commented Sep 7, 2017

This should also fix issues #9295, #9161, #9531.

@orlangur orlangur mentioned this pull request Sep 11, 2017
Closed
This was referenced Sep 17, 2017
Merged
Merged
magento-team pushed a commit that referenced this pull request Sep 22, 2017
@ishakhsuvarov
MAGETWO-75315: Backport #10739 - fix for translated attribute label c…
3bcff3e 
…omparison. #10932

 - Merge Pull Request #10932 from Januszpl/magento2:backport-10739
 - Merged commits:
   1. 257e7d9
   2. 622cd47
magento-team pushed a commit that referenced this pull request Sep 22, 2017
@vrann
MAGETWO-75315: Backport #10739 - fix for translated attribute label c…
eceb32b 
…omparison. #10932
@vrann vrann mentioned this pull request Oct 4, 2017
Merged
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@miguelbalparda miguelbalparda

Labels
Progress: accept
Projects
None yet
Milestone
September 2017
Development

Successfully merging this pull request may close these issues.
6 participants
@nowszy @magento-cicd2 @miguelbalparda @korostii @magento-team @ishakhsuvarov