Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

attribute.phtml does not respect translations #9531

Closed
steros opened this issue May 5, 2017 · 4 comments
Closed

attribute.phtml does not respect translations #9531

steros opened this issue May 5, 2017 · 4 comments
Labels
bug report duplicate Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed

Comments

@steros
Copy link
Contributor

steros commented May 5, 2017

Preconditions

  1. Magento 2.1.5
  2. Have some language pack
  3. Have some language other than english set for frontend

Steps to reproduce

  1. Enter a product description
  2. Call your product detail page

Expected result

  1. Above the product description should be no text

Actual result

  1. A label element with the translation of "none" is placed above the product description

I have made a quickfix here:
update attribute.phtml to respect translation [#9502]

But this will fail if you do not use the translation of "none" as that label. So there should be another way to determine that case.

@korostii
Copy link
Contributor

korostii commented May 5, 2017

Duplicate of #9161 and #9295

@steros
Copy link
Contributor Author

steros commented May 5, 2017

Thanks for linking!

@kweij
Copy link
Contributor

kweij commented Jul 12, 2017

@orlangur
Copy link
Contributor

Closing as duplicate of #9161.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug report duplicate Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed
Projects
None yet
Development

No branches or pull requests

5 participants