Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Simplified \Magento\Framework\Reflection\TypeProcessor #12324

Merged
merged 1 commit into from
May 16, 2018
Merged

Simplified \Magento\Framework\Reflection\TypeProcessor #12324

merged 1 commit into from
May 16, 2018

Conversation

joni-jones
Copy link
Contributor

Description

Simplified TypeProcessor methods to retrieve method param addition description and array param type

Testing scenarios

Covered by unit tests

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@orlangur orlangur self-assigned this Nov 17, 2017
@orlangur orlangur added this to the November 2017 milestone Nov 24, 2017
@joni-jones
Simplified TypeProcessor
41dad0a 
 - Removed `preg_match` usage for param description retrieving
 - Removed `preg_match` usage for param type retrieving
@okorshenko okorshenko modified the milestones: December 2017, January 2018 Jan 8, 2018
@okorshenko okorshenko modified the milestones: January 2018, February 2018 Feb 7, 2018
@okorshenko okorshenko modified the milestones: February 2018, March 2018 Mar 1, 2018
@okorshenko okorshenko modified the milestones: March 2018, April 2018 Apr 16, 2018
@magento-engcom-team magento-engcom-team merged commit 41dad0a into magento:2.2-develop May 16, 2018
magento-engcom-team pushed a commit that referenced this pull request May 16, 2018
MAGETWO-84477: Simplified \Magento\Framework\Reflection\TypeProcessor #…
783df04 
…12324
@magento-engcom-team
Copy link
Contributor

Hi @joni-jones. Thank you for your contribution.
Changes from your Pull Request will be available with the upcoming 2.2.5 release.

@hostep hostep mentioned this pull request Jun 14, 2018
Merged
4 tasks
@orlangur
Copy link
Contributor

@joni-jones @sidolov forwardport maybe?

@joni-jones joni-jones mentioned this pull request Jun 20, 2018
Merged
4 tasks
@joni-jones joni-jones deleted the type-processor-simplification branch July 2, 2018 07:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@orlangur orlangur

@sidolov sidolov

Labels
improvement Progress: accept Release Line: 2.2
Projects
None yet
Milestone
April 2018
Development

Successfully merging this pull request may close these issues.
5 participants
@joni-jones @magento-engcom-team @orlangur @okorshenko @sidolov