Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplified TypeProcessor #16275

Conversation

joni-jones
Copy link
Contributor

  • Removed preg_match usage for param description retrieving
  • Removed preg_match usage for param type retrieving

Forward port for #12324

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@magento-cicd2
Copy link
Contributor

magento-cicd2 commented Jun 20, 2018

CLA assistant check
Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.

@magento-engcom-team
Copy link
Contributor

Hi @joni-jones. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento-engcom-team give me test instance - deploy test instance based on Pull Request changes
  • @magento-engcom-team give me new test instance - deploy NEW test instance based on Pull Request changes
  • @magento-engcom-team give me {$VERSION} instance - deploy Vanilla Magento instance for Issue or Pull Request

For more details, please, review the Magento Contributor Assistant documentation

 - Removed `preg_match` usage for param description retrieving
 - Removed `preg_match` usage for param type retrieving
@joni-jones joni-jones force-pushed the 2.3-type-processor-simplification branch from e004e7d to badfe3c Compare June 20, 2018 17:19
@joni-jones joni-jones changed the title [Forward port] Simplified TypeProcessor Simplified TypeProcessor Jun 20, 2018
@orlangur orlangur self-assigned this Jun 20, 2018
Copy link
Contributor

@orlangur orlangur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@joni-jones nice! I really disliked the [\n\r]part.

@magento-engcom-team magento-engcom-team added this to the Release: 2.3.0 milestone Jun 20, 2018
@magento-engcom-team
Copy link
Contributor

Hi @orlangur, thank you for the review.
ENGCOM-2074 has been created to process this Pull Request

@magento-engcom-team
Copy link
Contributor

Hi @joni-jones. Thank you for your contribution.
Changes from your Pull Request will be available with the upcoming 2.3.0 release.

@joni-jones joni-jones deleted the 2.3-type-processor-simplification branch July 2, 2018 07:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants