Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Forwardport]Fix issue port 19328 - Success Message Icon vertically misaligned in admin panel #19334

Merged
merged 4 commits into from
Jan 31, 2019
Merged

[Forwardport]Fix issue port 19328 - Success Message Icon vertically misaligned in admin panel #19334

merged 4 commits into from
Jan 31, 2019

Conversation

speedy008
Copy link
Contributor

@speedy008 speedy008 commented Nov 22, 2018 •
edited
Loading

Original Pull Request

#19333

Description (*)

Success Message icon misaligned.

Fixed Issues (if relevant)

  1. Success Message Icon vertically misaligned in admin panel  #19328 : Success Message Icon vertically misaligned in admin panel

Manual testing scenarios (*)

1.Login to admin panel > System > Import.
2.Select necessary Option > Upload CSV.
3.Click on Check Data Button > Check success Message Icon

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@magento-engcom-team magento-engcom-team added Partner: Krish TechnoLabs partners-contribution Pull Request is created by Magento Partner labels Nov 22, 2018
@magento-engcom-team
Copy link
Contributor

Hi @speedy008. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento-engcom-team give me test instance - deploy test instance based on PR changes
  • @magento-engcom-team give me 2.3-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

@VladimirZaets VladimirZaets self-assigned this Nov 22, 2018
@magento-engcom-team magento-engcom-team added this to the Release: 2.3.1 milestone Nov 22, 2018
@magento-engcom-team
Copy link
Contributor

Hi @VladimirZaets, thank you for the review.
ENGCOM-3524 has been created to process this Pull Request

@speedy008 speedy008 added the Port label Nov 26, 2018
sivaschenko
sivaschenko reviewed Nov 26, 2018
View reviewed changes
app/design/adminhtml/Magento/backend/web/css/source/components/_messages.less Outdated
@@ -121,6 +121,15 @@
}
}

#import_validation_container {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@speedy008 can you please change the selector to avoid using the ID

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @sivaschenko
I have Updated code.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@sivaschenko
Copy link
Member

Hi @speedy008 Success Message Icon is vertically misaligned with phrase "Import successfully done"
image

@speedy008
Copy link
Contributor Author

@sivaschenko Can you explain whats the issue
As i have observe the Success Message Icon is vertically misaligned is already has been fixed but import icon still remain resolved

@sivaschenko
Copy link
Member

Hi @speedy008 do you mean that only verification success message icon has been fixed and not the icon shown after successful import? Is there a universal solution that can fix both icons?

@okorshenko okorshenko removed this from the Release: 2.3.1 milestone Jan 28, 2019
@speedy008
Copy link
Contributor Author

@sivaschenko I have create one common solution for vertically icon middle issue.

@sivaschenko
Copy link
Member

@magento-engcom-team give me test instance

@magento-engcom-team
Copy link
Contributor

Hi @sivaschenko. Thank you for your request. I'm working on Magento instance for you

@magento-engcom-team
Copy link
Contributor

Hi @sivaschenko, here is your new Magento instance.
Admin access: https://pr-19334.instances.magento-community.engineering/admin
Login: admin Password: 123123q

@speedy008 speedy008 mentioned this pull request Jan 30, 2019
Merged
4 tasks
@magento-engcom-team magento-engcom-team mentioned this pull request Jan 31, 2019
Closed
@magento-engcom-team magento-engcom-team merged commit da33798 into magento:2.3-develop Jan 31, 2019
@ghost
Copy link

ghost commented Jan 31, 2019

Hi @speedy008, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

@magento-engcom-team magento-engcom-team added this to the Release: 2.3.1 milestone Jan 31, 2019
magento-engcom-team pushed a commit that referenced this pull request Jan 31, 2019
@sidolov
ENGCOM-3524: [Forwardport]Fix issue port 19328 - Success Message Icon…
bee03b1 
… vertically misaligned in admin panel #19334
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sivaschenko sivaschenko sivaschenko approved these changes

@VladimirZaets VladimirZaets VladimirZaets approved these changes

Assignees

@sivaschenko sivaschenko

@VladimirZaets VladimirZaets

Labels
Area: Design/Frontend Award: bug fix Partner: Krish TechnoLabs partners-contribution Pull Request is created by Magento Partner Progress: accept Release Line: 2.3
Projects
None yet
Milestone
Release: 2.3.1
Development

Successfully merging this pull request may close these issues.
5 participants
@speedy008 @magento-engcom-team @sivaschenko @VladimirZaets @okorshenko