Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix issue 19328 - Success Message Icon vertically misaligned in admin panel #19333

Merged
merged 7 commits into from
Feb 11, 2019
Merged

Fix issue 19328 - Success Message Icon vertically misaligned in admin panel #19333

merged 7 commits into from
Feb 11, 2019

Conversation

speedy008
Copy link
Contributor

@speedy008 speedy008 commented Nov 22, 2018 •
edited
Loading

Description (*)

Success Message icon misaligned.

Fixed Issues (if relevant)

  1. Success Message Icon vertically misaligned in admin panel  #19328 : Success Message Icon vertically misaligned in admin panel

Manual testing scenarios (*)

1.Login to admin panel > System > Import.
2.Select necessary Option > Upload CSV.
3.Click on Check Data Button > Check success Message Icon

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@magento-engcom-team
Copy link
Contributor

Hi @speedy008. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento-engcom-team give me test instance - deploy test instance based on PR changes
  • @magento-engcom-team give me 2.2-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

@speedy008 speedy008 added Fixed in 2.2.x The issue has been fixed in 2.2 release line Reproduced on 2.3.x The issue has been reproduced on latest 2.3 release labels Nov 22, 2018
@VladimirZaets VladimirZaets self-assigned this Nov 22, 2018
@speedy008 speedy008 mentioned this pull request Nov 22, 2018
Merged
4 tasks
@speedy008 speedy008 removed the Fixed in 2.2.x The issue has been fixed in 2.2 release line label Nov 23, 2018
@sivaschenko sivaschenko added Progress: on hold and removed Reproduced on 2.3.x The issue has been reproduced on latest 2.3 release labels Jan 28, 2019
@speedy008
Copy link
Contributor Author

@sivaschenko i have done changes in this pull request as well from this PR #19334

@magento-engcom-team
Copy link
Contributor

Hi @sivaschenko, thank you for the review.
ENGCOM-4068 has been created to process this Pull Request

@sivaschenko
Copy link
Member

Hi @speedy008 there is an issue with this PR that was introduced to 2.3 by forward-port as well. Please see the screen shot:
image

@speedy008
Copy link
Contributor Author

@sivaschenko I have updated solution regarding error icon.

@speedy008 speedy008 mentioned this pull request Feb 8, 2019
Merged
4 tasks
@sivaschenko
Copy link
Member

@magento-engcom-team give me test instance

@magento-engcom-team
Copy link
Contributor

Hi @sivaschenko. Thank you for your request. I'm working on Magento instance for you

@magento-engcom-team
Copy link
Contributor

Hi @sivaschenko, here is your new Magento instance.
Admin access: https://pr-19333.instances.magento-community.engineering/admin
Login: admin Password: 123123q

@VasylShvorak
Copy link
Contributor

@magento-engcom-team give me test instance

@magento-engcom-team
Copy link
Contributor

Hi @VasylShvorak. Thank you for your request. I'm working on Magento instance for you

@magento-engcom-team
Copy link
Contributor

Hi @VasylShvorak, here is your new Magento instance.
Admin access: https://pr-19333.instances.magento-community.engineering/admin
Login: admin Password: 123123q

@magento-engcom-team magento-engcom-team mentioned this pull request Feb 11, 2019
Closed
@magento-engcom-team magento-engcom-team merged commit b7fa7f5 into magento:2.2-develop Feb 11, 2019
@ghost
Copy link

ghost commented Feb 11, 2019

Hi @speedy008, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

magento-engcom-team pushed a commit that referenced this pull request Feb 11, 2019
@sidolov
ENGCOM-4068: Fix issue 19328 - Success Message Icon vertically misali…
fa7dd3c 
…gned in admin panel #19333
@sidolov sidolov added this to the Release: 2.2.9 milestone Feb 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sivaschenko sivaschenko sivaschenko approved these changes

@cpartica cpartica Awaiting requested review from cpartica

@VladimirZaets VladimirZaets Awaiting requested review from VladimirZaets

Assignees

@sivaschenko sivaschenko

@VladimirZaets VladimirZaets

Labels
Area: Design/Frontend Award: bug fix Partner: Krish TechnoLabs partners-contribution Pull Request is created by Magento Partner Progress: accept Release Line: 2.2
Projects
None yet
Milestone
Release: 2.2.9
Development

Successfully merging this pull request may close these issues.
6 participants
@speedy008 @magento-engcom-team @sivaschenko @VasylShvorak @VladimirZaets @sidolov