Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Curl - allow setting HTTP version #19445

Closed
wants to merge 1 commit into from
Closed

Curl - allow setting HTTP version #19445

wants to merge 1 commit into from

Conversation

ghost
Copy link

@ghost ghost commented Nov 29, 2018

Description

Added allow for setting curl http version

Fixed Issues (if relevant)

  1. Magento/Framework/HTTP/Adapter/Curl.php doesn't allow setting HTTP version #19442: Magento/Framework/HTTP/Adapter/Curl.php doesn't allow setting HTTP version

Manual testing scenarios (*)

  1. Create new ZendClient $client
  2. Set HTTP version $client->setConfig(['httpversion' => CURL_HTTP_VERSION_1_1])
  3. Make a request $client->request()

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@magento-engcom-team magento-engcom-team added Partner: ISM eCompany Pull Request is created by partner ISM eCompany partners-contribution Pull Request is created by Magento Partner labels Nov 29, 2018
@magento-cicd2
Copy link
Contributor

magento-cicd2 commented Nov 29, 2018

CLA assistant check
All committers have signed the CLA.

@magento-engcom-team
Copy link
Contributor

Hi @SikailoISM. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento-engcom-team give me test instance - deploy test instance based on PR changes
  • @magento-engcom-team give me 2.3-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

@VladimirZaets
Copy link
Contributor

Hi @SikailoISM, please, sign CLA, otherwise, we can't process your pull request

@sidolov
Copy link
Contributor

sidolov commented Dec 17, 2018

Hi @SikailoISM , looks like source branch was removed. We can't process this PR without it.
I'm closing this PR now, please, restore branch and reopen PR if you wish to continue!

@sidolov sidolov closed this Dec 17, 2018
@ghost ghost mentioned this pull request Dec 17, 2018
4 tasks
@ghost
Copy link
Author

ghost commented Dec 17, 2018

#19845
restored pull request

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: Framework/HTTP Partner: ISM eCompany Pull Request is created by partner ISM eCompany partners-contribution Pull Request is created by Magento Partner Release Line: 2.3
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants