Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport] Curl - allow setting HTTP version #21234

Closed

Conversation

mage2pratik
Copy link
Contributor

Original Pull Request

#19845

Description

Added allow for setting curl http version

Fixed Issues (if relevant)

  1. Magento/Framework/HTTP/Adapter/Curl.php doesn't allow setting HTTP version #19442: Magento/Framework/HTTP/Adapter/Curl.php doesn't allow setting HTTP version

Manual testing scenarios (*)

  1. Create new ZendClient $client
  2. Set HTTP version $client->setConfig(['httpversion' => CURL_HTTP_VERSION_1_1])
  3. Make a request $client->request()

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

Additional information

  1. Curl - allow setting HTTP version #19445: Recovered Pull Request

@magento-engcom-team
Copy link
Contributor

Hi @mage2pratik. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento-engcom-team give me test instance - deploy test instance based on PR changes
  • @magento-engcom-team give me 2.2-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

@ghost
Copy link

ghost commented Feb 15, 2019

Backport by pull request owner: #21251

@osrecio osrecio self-assigned this Feb 15, 2019
@osrecio
Copy link
Member

osrecio commented Feb 15, 2019

I close this PR in favour of Owner Backport.

@osrecio osrecio closed this Feb 15, 2019
@ghost
Copy link

ghost commented Feb 15, 2019

Hi @mage2pratik, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

@mage2pratik mage2pratik deleted the 2.2-develop-PR-port-19845 branch February 15, 2019 08:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants