Fix for admin shipment, creditmemo, invoice pdf emulation

[ksz2013]

No description provided.

[NadiyaS]

Hi @ksz2013 ,
Please follow Magento coding Standarts in your code:

• property names SHOULD NOT be prefixed with a single underscore to indicate protected or private visibility.
• All non-public properties and methods SHOULD be private
• backward incompatible changes are not allowed:
  If you need to change constructor signature to inject new dependency within existing class, please make it in next way:
  • Introduce a private getter for the new dependency (getNewDependency() in the example below).
  • Within getNewDependency() method, use Magento\Framework\App\ObjectionManager::getInstance() to obtain the new dependency and initialize the member variable accordingly.
  • Use $this->getNewDependency() where ever that dependency is needed within the class
  • In unit tests use Reflection to make the member variable accessible and inject a mocked object
  • In the unit test class, as part of setUp(), inject the appropriate mock object for the new dependency ($newDependencyMock in the example below).
  • To discourage the use of the getter method else where outside the capacity of this specific fix, please mark it as @deprecated
  • E.g.

    magento2/lib/internal/Magento/Framework/Reflection/TypeProcessor.php

    Line 68 in 79c551b

    /**

[aakimov]

Hi @ksz2013,

Unfortunately we cannot accept your pull request as is.
It will be closed.

Thank you for your understanding and interest in Magento.

[gabrieldagama]

Hi @ksz2013. Thank you for your report.
The issue has been fixed in #31938 by @ProkopovVitaliy in 2.4-develop branch
Related commit(s):

• 98e089e2b3a29a481a999eac3f0e39815047e002
• 4b0bf14cbaef041ae6dea0f6e341ef08a12c2b17
• 017de9a326d18eb624b69fd9a4f67650bcfe1c8c
• 3682d87461e55ec6b25d04e64dcb1bff3740f76f
• 67e3881581e81f01b777d0db53945c94e68d27f7
• e7b3b4d3c63849dbebf26491021eba53bc7b8b50
• 8916deeaab1dfad091b43bca0797cd9f72f1a0de

The fix will be available with the upcoming 2.4.3 release.

[gabrieldagama]

Hi @ksz2013. Thank you for your report.
The issue has been fixed in #31809 by @vlmed in 2.4-develop branch
Related commit(s):

• b01435e75ef8a7a9daa045944988243669dac24f
• 7f1dd3f32e0dc50d041a051d422b18983dbe63ba

The fix will be available with the upcoming 2.4.3 release.

[gabrieldagama]

Hi @ksz2013. Thank you for your report.
The issue has been fixed in #31969 by @vlmed in 2.4-develop branch
Related commit(s):

• fad5e616c2c28be1ca7c10456bbc87d88720232e

The fix will be available with the upcoming 2.4.3 release.

[sidolov]

Hi @ksz2013. Thank you for your report.
The issue has been fixed in #33124 by @vlmed in 2.4-develop branch
Related commit(s):

• ff21e6db5d1efc0492e043addd5d201f040a06a3
• 52c72cd5a4f7f37d30407f7feccb2c1f8047776f

The fix will be available with the upcoming 2.4.3 release.

[sidolov]

Hi @ksz2013. Thank you for your report.
The issue has been fixed in #31894 by @vlmed in 2.4-develop branch
Related commit(s):

• a1f384c5a89035359a878fadc24fbab59f75b638

The fix will be available with the upcoming 2.4.3 release.

[sidolov]

Hi @ksz2013. Thank you for your report.
The issue has been fixed in #31774 by @vlmed in 2.4-develop branch
Related commit(s):

• baa80afed30285d967b0e534ed8c3ca0316835e6
• 372b700bf3d3dd79415d288d3b1f96f424c94253

The fix will be available with the upcoming 2.4.3 release.

[sidolov]

Hi @ksz2013. Thank you for your report.
The issue has been fixed in #31785 by @vlmed in 2.4-develop branch
Related commit(s):

• 6ae6cc5c015f32c43a74f2cba51590b4a42c8d73
• f51fd188464b5b65e193d7e9f491c6f83e59cf45

The fix will be available with the upcoming 2.4.3 release.

[sidolov]

Hi @ksz2013. Thank you for your report.
The issue has been fixed in #34171 by @ravi-chandra3197 in 2.4-develop branch
Related commit(s):

• 380584144530211bdc3e04ad2020e33ffe61a1a1

The fix will be available with the upcoming 2.4.3 release.

[sidolov]

Hi @ksz2013. Thank you for your report.
The issue has been fixed in #31877 by @vlmed in 2.4-develop branch
Related commit(s):

• 0ba47679d16ad1fed3166ca9427ebb992ee5d93c
• 4372776d416ec51202d8b829c7c8415348122880
• bf63f1aeb59076d3b54fb73c31e090baa22f91b1

The fix will be available with the upcoming 2.4.3 release.

[sidolov]

Hi @ksz2013. Thank you for your report.
The issue has been fixed in #34620 by @ravi-chandra3197 in 2.4-develop branch
Related commit(s):

• f2daffdc95a9cf1f7220b08c8f887e1d049350ea

The fix will be available with the upcoming release.