update attribute.phtml to respect translation

[steros]

$_attributeLabel contains the translated label which then fails marvelously if your language isn't English.
This is more of a quick fix cause if you do not use the translation of 'none' for an empty attribute it will still fail :(

Description

Fixed Issues (if relevant)

1. magento/magento2#<issue_number>: Issue title
2. ...

Manual testing scenarios

1. ...
2. ...

Contribution checklist

• Pull request has a meaningful description of its purpose
• All commits are accompanied by meaningful commit messages
• All new or changed code is covered with unit/integration tests (if applicable)
• All automated tests passed successfully (all builds on Travis CI are green)

[davidmonichi]

For me the fix above was not enough. The label of short_description was translated so the fixed helped but then I had some troubles with the attributeLabel of field description which is not translated. Therefore I fixed it with:

<?php if ($_attributeLabel != __('none') && $_attributeLabel != 'none'): ?><strong class="type"><?php /* @escapeNotVerified */ echo $_attributeLabel?></strong><?php endif; ?>

Don't know if its okay to do it this way. Only to let you know.

[steros]

Yeah you are right I just stumbled over this too!

[davidmonichi]

Hi, I did again some research and found out that the main problem is that the short_description should actually not be translated, see issue #6218. Not sure which fix should be merged.

[steros]

Ah at work I don't have that much time to research and even so I wouldn't for magento to be honest.
If it's true that the label shouldn't be translated then #6257 would be the better fix I guess.

[mzeis]

Hi @steros, thanks for creating the ticket!

As the PR #6257 was accepted and merged into develop, would you be okay if I close this PR?

[steros]

That's all right. Thanks everyone for the involvement.