Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Backport of MAGETWO-53010 for Magento 2.1: Saving a custom transactional email logo, failed. #9590

Merged
merged 1 commit into from
May 15, 2017
Merged

Backport of MAGETWO-53010 for Magento 2.1: Saving a custom transactional email logo, failed. #9590

merged 1 commit into from
May 15, 2017

Conversation

hostep
Copy link
Contributor

@hostep hostep commented May 10, 2017 •
edited
Loading

Description

This is a backport of issue MAGETWO-53010 for Magento 2.1

Fixed Issues (if relevant)

  1. Magento 2.1 email logo image function does not work #5352: Magento 2.1 email logo image function does not work
  2. Magento 2.1 fails to load email_logo.png #5633: Magento 2.1 fails to load email_logo.png
  3. Magento 2.1 transactional email uploaded logo not showing in admin. #5916: Magento 2.1 transactional email uploaded logo not showing in admin.
  4. Transactional Email Logo Not Getting Updated #6275: Transactional Email Logo Not Getting Updated
  5. New order email header logo not showing correctly v2.1 #6420: New order email header logo not showing correctly v2.1
  6. Can't save Logo Image to Transactional Emails #6502: Can't save Logo Image to Transactional Emails
  7. Transactional email logo wrong location #7853: Transactional email logo wrong location
  8. Logo email #7985: Logo email
  9. Magento 2.1.4 - Asking Why Email Logo Never been fixed on all Magento releases #8489: Magento 2.1.4 - Asking Why Email Logo Never been fixed on all Magento releases
  10. Transactional Emails Logo #8728: Transactional Emails Logo
  11. email logo error #8961: email logo error
  12. transactional email #9118: transactional email
  13. Magento 2.1.2 - 2.1.4 email logo image function does not work #8626: Magento 2.1.2 - 2.1.4 email logo image function does not work

Wow, it took me longer to compile a list of all the issues then to actually create the backport :p
And I probably even forgot some...

Reference to the commits on the develop branch:

@hostep
Backport of MAGETWO-53010 for Magento 2.1: Saving a custom transactio…
0dfaf62 
…nal email logo, failed.

MAGETWO-53010: [Email Logo] Saving a custom transactional email logo, failed.

(cherry picked from commit 23103c0)

MAGETWO-53010: [Email Logo] Saving a custom transactional email logo, failed.

(cherry picked from commit cb603ff)
@okorshenko okorshenko self-assigned this May 10, 2017
@okorshenko okorshenko added this to the May 2017 milestone May 10, 2017
@okorshenko
Copy link
Contributor

okorshenko commented May 10, 2017 •
edited
Loading

@hostep Thank you for this PR. Looks like lots of issues should be fixed. We will start testing this on our side.

@korostii
Copy link
Contributor

korostii commented May 11, 2017 •
edited
Loading

@okorshenko,
Technically, these would be multiple duplicates of the same issue.
Reported once again, and then again, and again, and so on.
All because the issue was told to be "fixed and delivered to develop branch" yet it never reached any released 2.1.x version.

(Just a reminder that marking the bug as "fixed and delivered to develop branch" doesn't solve the any issues for the regular users)

@magento-team magento-team merged commit 0dfaf62 into magento:2.1-develop May 15, 2017
magento-team pushed a commit that referenced this pull request May 15, 2017
MAGETWO-69062: Backport of MAGETWO-53010 for Magento 2.1: Saving a cu…
f7f6c1f 
…stom transactional email logo, failed. #9590
@magento-team
Copy link
Contributor

@hostep thank you for your contribution. Your Pull Request has been successfully merged

This was referenced May 15, 2017
Closed
Closed
Closed
@okorshenko
Copy link
Contributor

@korostii This issue was fixed in 2.1-develop branch. This means that it will be available in the upcoming patch releases for Magento 2.1

@hostep hostep mentioned this pull request Jun 15, 2017
Closed
@korostii korostii mentioned this pull request Jun 26, 2017
Closed
@DnDDeployer
Copy link

@okobchenko Do you have a date for this release?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@okorshenko okorshenko

Labels
bugfix Progress: accept Release Line: 2.1
Projects
None yet
Milestone
May 2017
Development

Successfully merging this pull request may close these issues.
5 participants
@hostep @okorshenko @korostii @magento-team @DnDDeployer