Make DPI code link dynamically #36
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Support older Windows Versions
|
Thanks Joel. I pushed the DPI code prematurely, see #33. It's all still a work in progress. |
|
Yes I realized. Thats why I just tried to “fix it a little bit”, since currently it crashes on everything older than some windows 10 version. (Still got lab computers nobody wants to update :/ ) |
|
I see you disabled most of the code for now. Still |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support older Windows Versions
I am unable to fully test this code as I lack the hardware.
I however think this code is still (functionally) broken tbh. GLFW is imho supposed to handle these APIs (they dynload these functions themselves on init). If I'm correct they also specify to support multiple monitors with different DPI (what happens on moving a window? Do we need to change the resolution imgui is drawing etc?). I think the correct way is to set the GLFW hint for HDPI awareness and use
glfwGetMonitorContentScale(Which more or less does what we are doing now). to get the scale every time it's needed - replacing the field. Also handling different x/y scaling.