Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: poll review link & no delegate migration for shadow delegates #817

Merged
merged 2 commits into from
Aug 9, 2023

Conversation

hernandoagf
Copy link
Collaborator

@hernandoagf hernandoagf commented Aug 8, 2023

Link to Shortcut ticket:

https://app.shortcut.com/dux-makerdao/story/2412/update-poll-detail-links
https://app.shortcut.com/dux-makerdao/story/2405/remove-migration-banner-for-shadow-delegates

What does this PR do?

  • Add a link to the poll copy review section in the poll detail page
  • Check if the user delegate address is a shadow delegate, and if so, hide the delegate migration banner

@vercel
Copy link

vercel bot commented Aug 8, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
governance-portal-v2 ✅ Ready (Inspect) Visit Preview Aug 8, 2023 7:17pm

@hernandoagf hernandoagf changed the title Add poll copy url to poll details page Feat: poll review link & no delegate migration for shadow delegates Aug 8, 2023
@adamgoth adamgoth merged commit 42b4273 into develop Aug 9, 2023
3 of 4 checks passed
@adamgoth adamgoth deleted the poll-detail-review-link branch August 9, 2023 07:11
adamgoth added a commit that referenced this pull request Aug 9, 2023
* 0.11.5

* Feat: poll review link & no delegate migration for shadow delegates (#817)

* Add poll copy url to poll details page

* Remove migration banner for shadow delegates

* Feat:  AVCs page (#815)

* feat: Add functions and modules for AVCs page

* Add AVC UI components

* Fetch AVC delegate count and MKR delegated

* Add AVC list page

* Use delegate system stats for delegate pages

* Add new Endgame FAQ links

* Parse and limit length of AVC description

* Remove "View AVC details" button

* Add AVC link in mobile navigation menu

* Fix spec

---------

Co-authored-by: Adam Goth <[email protected]>

* Bump version

* Disable AVC detail link on avatar

* Edit link titles

* Hide view button if no delegates for AVC exist

* make test amount a variable

---------

Co-authored-by: b-pmcg <[email protected]>
Co-authored-by: Hernando Guzmán <[email protected]>
adamgoth added a commit that referenced this pull request Sep 13, 2023
* 0.11.5

* Feat: poll review link & no delegate migration for shadow delegates (#817)

* Add poll copy url to poll details page

* Remove migration banner for shadow delegates

* Feat:  AVCs page (#815)

* feat: Add functions and modules for AVCs page

* Add AVC UI components

* Fetch AVC delegate count and MKR delegated

* Add AVC list page

* Use delegate system stats for delegate pages

* Add new Endgame FAQ links

* Parse and limit length of AVC description

* Remove "View AVC details" button

* Add AVC link in mobile navigation menu

* Fix spec

---------

Co-authored-by: Adam Goth <[email protected]>

* Bump version

* Disable AVC detail link on avatar

* Edit link titles

* Hide view button if no delegates for AVC exist

* make test amount a variable

* Bump protobufjs from 6.11.3 to 6.11.4 (#819)

Bumps [protobufjs](https://github.com/protobufjs/protobuf.js) from 6.11.3 to 6.11.4.
- [Release notes](https://github.com/protobufjs/protobuf.js/releases)
- [Changelog](https://github.com/protobufjs/protobuf.js/blob/master/CHANGELOG.md)
- [Commits](https://github.com/protobufjs/protobuf.js/commits)

---
updated-dependencies:
- dependency-name: protobufjs
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Bump @adobe/css-tools from 4.2.0 to 4.3.1 (#820)

Bumps [@adobe/css-tools](https://github.com/adobe/css-tools) from 4.2.0 to 4.3.1.
- [Changelog](https://github.com/adobe/css-tools/blob/main/History.md)
- [Commits](https://github.com/adobe/css-tools/commits)

---
updated-dependencies:
- dependency-name: "@adobe/css-tools"
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* show all avcs button, match button styles

* update vote proxy text and links

* remove available soon

* Bump version

---------

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: b-pmcg <[email protected]>
Co-authored-by: Hernando Guzmán <[email protected]>
Co-authored-by: Adam Goth <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Tyler <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants