Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix MetaMask connection on Firefox #849

Merged
merged 4 commits into from
Jan 10, 2024
Merged

Conversation

hernandoagf
Copy link
Collaborator

What does this PR do?

Fix an issue that prevents MetaMask from connecting on Firefox

Copy link

vercel bot commented Jan 10, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
governance-portal-v2 ✅ Ready (Inspect) Visit Preview Jan 10, 2024 8:29pm

Copy link

what-the-diff bot commented Jan 10, 2024

PR Summary

  • Enhanced Security in Script Source
    The update has included additional security parameters ('unsafe-eval' 'unsafe-inline') to the script source directive in a segment of our middleware code called cspHeader. This helps in improving protection against any harmful scripts.

  • Account Selection Improvement
    A new function called checkInjectedProvider has been incorporated into AccountSelect.tsx. By checking the availability of selected account providers, it ensures seamless user experience.

  • Provider Checking Functionality
    We've now created a new function named checkInjectedProvider, which helps validate the presence of certain necessary providers. It makes our system more reliable and less prone to errors.

  • New Function in Connection Process
    The same checkInjectedProvider function is applied in the connection process script, useEagerlyConnect.ts, to bolster the robustness of the connection mechanism.

  • Library Dependencies Addition
    The updated package.json file now includes dependencies for @metamask/post-message-stream and @metamask/providers. These additions provide us with enhanced functionalities and help us integrate more effectively with Metamask services.

Copy link

New dependencies detected. Learn more about Socket for GitHub ↗︎

Packages Version New capabilities Transitives Size Publisher
@metamask/post-message-stream 7.0.0 None +13 4.57 MB gudahtt
@metamask/providers 14.0.2 filesystem +21 5.4 MB metamaskbot

@tyler17 tyler17 merged commit a8203b4 into develop Jan 10, 2024
3 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants