Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

more tenderly updates #876

Merged
merged 2 commits into from
Apr 24, 2024
Merged

more tenderly updates #876

merged 2 commits into from
Apr 24, 2024

Conversation

adamgoth
Copy link
Collaborator

@adamgoth adamgoth commented Apr 24, 2024

Pull github mainnet info when on tenderly
Add tenderly spock URL

Copy link

vercel bot commented Apr 24, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
governance-portal-v2 ✅ Ready (Inspect) Visit Preview Apr 24, 2024 0:58am

Copy link
Collaborator

@hernandoagf hernandoagf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just a comment on the repos

@@ -22,6 +22,7 @@ export function getAvcsRepositoryInformation(network: SupportedNetworks): Reposi
page: 'delegates/templates'
};

const avcsRepositoryInfo = network === SupportedNetworks.MAINNET ? repoMainnet : repoTest;
const avcsRepositoryInfo =
network === SupportedNetworks.MAINNET || network === SupportedNetworks.TENDERLY ? repoMainnet : repoTest;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If the plan is to only support Mainnet and Tenderly I think this can just point to the mainnet repo (no need for test repo). Same for the delegates repo in the following file

@tyler17 tyler17 self-requested a review April 24, 2024 19:51
@tyler17 tyler17 merged commit c9f1993 into tenderly Apr 24, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants