-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add polling e2e #890
add polling e2e #890
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
PR Summary
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You mentioned gasless not working but I see a couple things commented out in the esmodule
test. Was this intentional?
Tried to add a test for gasless voting, but it seems that our mock connector doesn't support eth_signTypedData_v4. We create the mock connector by extending ether's Eip1193Bridge, which doesn't support sign typed data. So it would be a bit of to update it to handle it I think, I left that test skipped.