Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add polling e2e #890

Merged
merged 8 commits into from
Jun 19, 2024
Merged

add polling e2e #890

merged 8 commits into from
Jun 19, 2024

Conversation

tyler17
Copy link
Collaborator

@tyler17 tyler17 commented May 26, 2024

  • add a test to poll vote with legacy system

Tried to add a test for gasless voting, but it seems that our mock connector doesn't support eth_signTypedData_v4. We create the mock connector by extending ether's Eip1193Bridge, which doesn't support sign typed data. So it would be a bit of to update it to handle it I think, I left that test skipped.

@tyler17 tyler17 added the WIP label May 26, 2024
Copy link

vercel bot commented May 26, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
governance-portal-v2 ✅ Ready (Inspect) Visit Preview Jun 4, 2024 0:36am

Copy link

what-the-diff bot commented May 26, 2024

PR Summary

  • Introduction of a New Workflow - "e2e.yml"
    This update adds a new workflow file named "e2e.yml". This workflow orchestrates certain automated tasks that help us ensure our code works as expected.

  • Addition of End-to-End Test File - "polling.spec.ts"
    The new workflow includes a testing file, "polling.spec.ts", located in the "playwright" directory. This test file focuses on examining practical functionalities of our application such as adding polls to reviews, navigating within the review page, and interaction with an older system.

  • Extensive Functionality Validation
    The "polling.spec.ts" file doesn't stop at basic function checks, it also emulates user interactions like button clicking and validates the entire process. This helps us guarantee a seamless user experience.

Copy link
Collaborator

@adamgoth adamgoth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You mentioned gasless not working but I see a couple things commented out in the esmodule test. Was this intentional?

@tyler17 tyler17 merged commit 3b7e4a6 into develop Jun 19, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants