Adds Vector3, Matrix3, Quaternion, RollPitchYaw and api::Rotation bindings #43
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Franco Cipollone <[email protected]>
Signed-off-by: Franco Cipollone <[email protected]>
Signed-off-by: Franco Cipollone <[email protected]>
Signed-off-by: Franco Cipollone <[email protected]>
Signed-off-by: Franco Cipollone <[email protected]>
This was referenced Mar 18, 2024
| std::unique_ptr<Matrix3> Matrix3_new(double m00, double m01, double m02, | ||
| double m10, double m11, double m12, | ||
| double m20, double m21, double m22) { | ||
| return std::make_unique<Matrix3>(std::initializer_list<double>{m00, m01, m02, m10, m11, m12, m20, m21, m22}); |
There was a problem hiding this comment.
Should add
#include <initializer_list>| rust::String Quaternion_to_str(const Quaternion& self) { | ||
| std::stringstream ss; | ||
| ss << self; | ||
| return {ss.str()}; |
There was a problem hiding this comment.
We may want to add to_str() method to the Quaternion class.
maliput-sys/tests/math_test.rs
Outdated
Comment on lines
230
to
232
| let m = Matrix3_new(1.0, 2.0, 3.0, 4.0, 5.0, 6.0, 7.0, 8.0, 9.0); | ||
| let t = Matrix3_transpose(&m); | ||
| assert_eq!(Matrix3_row(&m, 1).z(), Matrix3_row(&t, 2).y()); |
There was a problem hiding this comment.
Suggested change
| let m = Matrix3_new(1.0, 2.0, 3.0, 4.0, 5.0, 6.0, 7.0, 8.0, 9.0); | |
| let t = Matrix3_transpose(&m); | |
| assert_eq!(Matrix3_row(&m, 1).z(), Matrix3_row(&t, 2).y()); | |
| let m = Matrix3_new(1.0, 2.0, 3.0, 4.0, 5.0, 6.0, 7.0, 8.0, 9.0); | |
| let t = Matrix3_transpose(&m); | |
| let n = Matrix3_new(1.0, 4.0, 7.0, 2.0, 5.0, 8.0, 3.0, 6.0, 9.0); | |
| assert_eq!(Matrix3_equals(&t, &n)); |
There was a problem hiding this comment.
Thanks. Done
Signed-off-by: Franco Cipollone <[email protected]>
|
I accidentaly merged #44 which uses this PR's branch as target. So I will continue as this is. |
francocipollone
changed the title
Signed-off-by: Franco Cipollone <[email protected]>
Signed-off-by: Franco Cipollone <[email protected]>
|
I will go ahead and merge this PR to unblock future PRs. Feel free to drop a review and we can work on a follow-up PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎉 New feature
Related to #11 #14
Summary
FFI Bindings for:
Rust API for:
Adds RollPitchYaw and Rotation bindings and Rust API #44 was merged into this branch/PR
Checklist