Adds RollPitchYaw and Rotation bindings and Rust API #44
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Franco Cipollone <[email protected]>
Signed-off-by: Franco Cipollone <[email protected]>
This was referenced Mar 19, 2024
| @@ -416,6 +416,91 @@ impl std::fmt::Debug for Quaternion { | |||
| } | |||
| } | |||
|
|
|||
| /// This class represents the orientation between two arbitrary frames A and D | |||
There was a problem hiding this comment.
Willing to reduce labor, shall we point code documentation to the C++ doxygen code instead of copy-pasting here all the stuff? I think it makes more sense given that it'll be a maintenance burden to have duplicated docs for the bindings. It just simply doesn't scale IMO.
There was a problem hiding this comment.
Context:
- With cargo the creation of the documentation is trivial. (cargo doc).
- The cargo packages being pushed to crate.io automatically create online documentation at: https://docs.rs/
It is a trade-off at the end but I do see value on having populated documentation on the rust side even though it may require some extra effort for maintenance.
|
I will proceed with this and merge it however we can tackle this discussion F2F. |
francocipollone
merged commit 64129f5
into
francocipollone/more_math_covering
3 checks passed
6 tasks
francocipollone
added a commit
that referenced
this pull request
Mar 25, 2024
…dings (#43) * Adds Vector4 bindings * Adds FFI bindings for Matrix3. * Adds Rust API for Matrix3 * Adds FFI bindings for Quaternion class. * Adds Rust API of Quaternion class. * Adds RollPitchYaw and Rotation bindings and Rust API (#44) Signed-off-by: Franco Cipollone <[email protected]>
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎉 New feature
Goes on top of #43
Related to #11 #14 #17 #28
Checklist