-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Removes dashing support. #253
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
BTW, aren't you removing the docker images for bionic? |
Forgot to comment about it, thanks for asking. Even though we are removing support to 18, I felt that there is no harm about having the script allowing you to set up a 18.04 container if needed. However, for consistency I think I should remove it and avoid having to maintain this in the future. Wdyt? I guess you're inclined to remove it, right? |
Git tracks everything :) No harm in removing it. |
Interesting to extend it for all the repos not only maliput_infra. Adding in maliput_documentation a note with the hashes of all the repos with official dashing support? |
Right. |
Actually, that's what tags are for :) |
To continue here: #254 |
CI passing. maliput/delphyne#842 Is fixing delphyne test. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Part of #249