Adds a SimpleObjectQuery implementation
#17
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
francocipollone
force-pushed
the
francocipollone/object_query_simple_impl
branch
from
d4bc441
to
d57104d
Compare
francocipollone
force-pushed
the
francocipollone/object_query_simple_impl
branch
from
d57104d
to
d4444d6
Compare
francocipollone
commented
May 4, 2022
| } else if (overlapping_type == api::OverlappingType::kContained) { | ||
| MALIPUT_THROW_MESSAGE("Not implemented yet for kContained overlapping type."); | ||
| } else { | ||
| MALIPUT_THROW_MESSAGE("Not implemented yet for kDisjointed overlapping type."); |
There was a problem hiding this comment.
For kDisjointed implementation, I will simply do the complement of the intersected lanes.
francocipollone
commented
May 4, 2022
| if (overlapping_type == api::OverlappingType::kIntersected) { | ||
| return overlapping_lanes; | ||
| } else if (overlapping_type == api::OverlappingType::kContained) { | ||
| MALIPUT_THROW_MESSAGE("Not implemented yet for kContained overlapping type."); |
There was a problem hiding this comment.
This implementation is a bit trickier. To ensure that the entire lane is within a certain region, I should kind of sample the lane and evaluate those points. Given that the geometry of the lane isn't something that can be guaranteed.
There was a problem hiding this comment.
Left as technical debt: #22
agalbachicar
requested changes
May 9, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Addresses #18
Creates a
SimpleObjectQueryimplementationThis implementation uses extensively maliput's methods like
ToLanePositionandFindRoadPositionsSome tests are being added at maliput/maliput_integration_tests#63
Goes on top of #7