inufuku.cpp: Merge */inufuku.* into drivers/inufuku.cpp, Minor cleanups #8172
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove unnecessary VRAM read trampolines Use buffered_spriteram16_device for buffered sprite RAM Use clock related to XTALs Reduce runtime tag lookups, Unnecessary region size Fix namngs, spacings Use generic gfx layouts, Fix color usage of gfxdecode related to palette amount Restrict rowscroll with screen cliprect Reduce unnecessary lines Use shorter/correct type values
|
Can you move everything to the driver file? It's small enough so that it doesn't need to be split. |
Add optional logging for debugging Fix line usages, Fix initialize
cam900
changed the title
|
You may as well put it in an anonymous namespace for the marginal link time improvement while you’re at it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove unnecessary VRAM read trampolines
Use buffered_spriteram16_device for buffered sprite RAM
Use clock related to XTALs
Reduce runtime tag lookups, Unnecessary region size
Add logerror for debugging
Fix initialize
Fix namngs, spacings
Use generic gfx layouts, Fix color usage of gfxdecode related to palette amount
Restrict rowscroll with screen cliprect
Reduce unnecessary lines
Use shorter/correct type values