Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

spinner overwritten in Jupyter on Windows #141

Open
norweeg opened this issue Mar 7, 2020 · 0 comments · May be fixed by #144
Open

spinner overwritten in Jupyter on Windows #141

norweeg opened this issue Mar 7, 2020 · 0 comments · May be fixed by #144

Comments

@norweeg
Copy link

norweeg commented Mar 7, 2020

@manrajgrover yep, already found the line in your code. I'll try to fix it for you. I get that terminal support sucks, but you shouldn't be preventing it in Jupyter on Windows....

Originally posted by @norweeg in #25 (comment)

There is no reason to overwrite spinner value in Jupyter Notebook on any platform
norweeg pushed a commit to norweeg/halo that referenced this issue Mar 7, 2020
halonotebook no longer overwrite spinner on Windows
5533c1a 
resolves manrajgrover#141
This was referenced Mar 7, 2020
Closed
Open
norweeg pushed a commit to norweeg/halo that referenced this issue Mar 7, 2020
remove unnecessary system check for Unicode output
0d582d7 
resolves manrajgrover#5
resolves manrajgrover#25
resolves manrajgrover#141
obsoletes manrajgrover#142
@norweeg norweeg linked a pull request Mar 7, 2020 that will close this issue
Open
3 tasks
norweeg pushed a commit to norweeg/halo that referenced this issue Aug 4, 2020
remove unnecessary system check for Unicode output
6ae75b8 
resolves manrajgrover#5
resolves manrajgrover#25
resolves manrajgrover#141
obsoletes manrajgrover#142
norweeg pushed a commit to norweeg/halo that referenced this issue Aug 4, 2020
halonotebook no longer overwrite spinner on Windows
fd6d5fb 
resolves manrajgrover#141
norweeg pushed a commit to norweeg/halo that referenced this issue Nov 24, 2020
@norweeg
remove unnecessary system check for Unicode output
ae8b95a 
resolves manrajgrover#5
resolves manrajgrover#25
resolves manrajgrover#141
obsoletes manrajgrover#142
norweeg pushed a commit to norweeg/halo that referenced this issue Nov 24, 2020
@norweeg
halonotebook no longer overwrite spinner on Windows
36a4d0d 
resolves manrajgrover#141
norweeg added a commit to norweeg/halo that referenced this issue Nov 24, 2020
@norweeg
remove unnecessary system check for Unicode output
fb05022 
resolves manrajgrover#5
resolves manrajgrover#25
resolves manrajgrover#141
obsoletes manrajgrover#142
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
1 participant
@norweeg