fixed overwrite of spinner value with default spinner in Jupyter Notebooks running on Windows #142
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 430
💛 - Coveralls |
norweeg
changed the title
norweeg
pushed a commit
to norweeg/halo
that referenced
this pull request
Mar 7, 2020
resolves manrajgrover#5 resolves manrajgrover#25 resolves manrajgrover#141 obsoletes manrajgrover#142
norweeg
pushed a commit
to norweeg/halo
that referenced
this pull request
Aug 4, 2020
resolves manrajgrover#5 resolves manrajgrover#25 resolves manrajgrover#141 obsoletes manrajgrover#142
norweeg
force-pushed
the
halonotebook-fix-spinners
branch
from
5533c1a
to
fd6d5fb
Compare
norweeg
pushed a commit
to norweeg/halo
that referenced
this pull request
Nov 24, 2020
resolves manrajgrover#5 resolves manrajgrover#25 resolves manrajgrover#141 obsoletes manrajgrover#142
norweeg
force-pushed
the
halonotebook-fix-spinners
branch
from
fd6d5fb
to
9a01ed6
Compare
norweeg
added a commit
to norweeg/halo
that referenced
this pull request
Nov 24, 2020
resolves manrajgrover#5 resolves manrajgrover#25 resolves manrajgrover#141 obsoletes manrajgrover#142
|
made obsolete by #144 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of new feature, or changes
Removed check of OS causing spinner value to be overwritten with default value in Jupyter Notebook on Windows. If you went to the trouble to use HaloNotebook, you are almost certainly using a browser-based notebook capable of rendering the spinner
Resolves #141
Checklist
Related Issues and Discussions
People to notify