Add Reformed User Agent to Telemetry Client #437
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #437 +/- ##
============================================
+ Coverage 68.23% 68.65% +0.42%
- Complexity 383 394 +11
============================================
Files 68 69 +1
Lines 2084 2144 +60
Branches 163 171 +8
============================================
+ Hits 1422 1472 +50
- Misses 571 575 +4
- Partials 91 97 +6 |
harvsu
force-pushed
the
user-agent-reform-add-no-replacement
branch
3 times, most recently
from
3cb8fb5
to
ce08195
Compare
harvsu
changed the title
nkukday
reviewed
Nov 21, 2019
libtelemetry/src/test/java/com/mapbox/android/telemetry/TelemetryClientTest.java
Outdated
Show resolved
Hide resolved
harvsu
force-pushed
the
user-agent-reform-add-no-replacement
branch
from
2c93fb3
to
98ab3fb
Compare
nkukday
reviewed
Nov 21, 2019
libtelemetry/src/androidTest/java/com/mapbox/android/telemetry/TestReformedUserAgent.java
Outdated
Show resolved
Hide resolved
alfwatt
approved these changes
Nov 21, 2019
libcore/src/main/java/com/mapbox/android/core/MapboxSdkInfoForUserAgentGenerator.java
Outdated
Show resolved
Hide resolved
nkukday
reviewed
Nov 21, 2019
libtelemetry/src/main/java/com/mapbox/android/telemetry/TelemetryUtils.java
Outdated
Show resolved
Hide resolved
nkukday
reviewed
Nov 21, 2019
libtelemetry/src/main/java/com/mapbox/android/telemetry/TelemetryUtils.java
Outdated
Show resolved
Hide resolved
harvsu
force-pushed
the
user-agent-reform-add-no-replacement
branch
4 times, most recently
from
891df30
to
026e432
Compare
|
let's update |
harvsu
force-pushed
the
user-agent-reform-add-no-replacement
branch
from
026e432
to
b3c6ec7
Compare
alfwatt
reviewed
Nov 22, 2019
libcore/src/main/java/com/mapbox/android/core/MapboxSdkInfoForUserAgentGenerator.java
Show resolved
Hide resolved
alfwatt
reviewed
Nov 22, 2019
libtelemetry/src/main/java/com/mapbox/android/telemetry/TelemetryClient.java
Outdated
Show resolved
Hide resolved
harvsu
force-pushed
the
user-agent-reform-add-no-replacement
branch
from
1b9109c
to
f697df1
Compare
Spec: mapbox/mobile-telemetry#423 Add new User agent with header X-Mapbox-User-Agent in addition to current user agent. The new user agent is constructed from host app and Mapbox libraries version information. Update the version for android-sdk-versions-plugin. Update copyright year to 2018-2019 in LICENSE.MD Change publishing license from "The Apache Software License, Version 2.0" to "The MIT License" for consistency. * check params and init client before setting base url * change setBaseUrl() to return boolean fix: typo displacemnt => displacement (#438)
harvsu
force-pushed
the
user-agent-reform-add-no-replacement
branch
from
e2a72bc
to
e587698
Compare
… user-agent-reform-add-no-replacement
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Auto generate the user agent to include host application and all Mapbox libraries version information according to the following specification.
mapbox/mobile-telemetry#423
Add New user agent(with header
X-Mapbox-User-Agent) to network requests sent via TelemetryClient (not ConfigurationClient) in addition to the existing user agent that is currently in production.Host Application information is read from package information available at run time and Mapbox library information is available in assets folder (#435). This change reads the information and builds the user agent per format described in the specification.
Note: The new user agent will eventually replace the existing one after the backend is ready to accept this.