Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: typo displacemnt => displacement #438

Merged
merged 1 commit into from
Nov 22, 2019
Merged

Conversation

ferdicus
Copy link
Contributor

boyscouting - saw a typo and fixed all occurrences of it

@harvsu harvsu requested review from harvsu and removed request for harvsu November 22, 2019 18:36
@codecov
Copy link

codecov bot commented Nov 22, 2019

Codecov Report

Merging #438 into master will not change coverage.
The diff coverage is 100%.

@@            Coverage Diff            @@
##             master     #438   +/-   ##
=========================================
  Coverage     68.23%   68.23%           
  Complexity      383      383           
=========================================
  Files            68       68           
  Lines          2084     2084           
  Branches        163      163           
=========================================
  Hits           1422     1422           
  Misses          571      571           
  Partials         91       91

@harvsu
Copy link
Contributor

harvsu commented Nov 22, 2019

@ferdicus Thanks for the fix and pull request.

@harvsu harvsu self-requested a review November 22, 2019 19:29
Copy link
Contributor

@harvsu harvsu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved!

@harvsu harvsu merged commit 309f33f into mapbox:master Nov 22, 2019
harvsu pushed a commit that referenced this pull request Nov 22, 2019
Spec: mapbox/mobile-telemetry#423
Add new User agent with header X-Mapbox-User-Agent in addition to current user agent.
The new user agent is constructed from host app and Mapbox libraries version information.
Update the version for android-sdk-versions-plugin.
Update copyright year to 2018-2019 in LICENSE.MD
Change publishing license from "The Apache Software License, Version 2.0" to "The MIT License" for consistency.

* check params and init client before setting base url

* change setBaseUrl() to return boolean

fix: typo displacemnt => displacement (#438)
harvsu added a commit that referenced this pull request Nov 22, 2019
Spec: mapbox/mobile-telemetry#423
Add new User agent with header X-Mapbox-User-Agent in addition to current user agent.
The new user agent is constructed from host app and Mapbox libraries version information.
Update the version for android-sdk-versions-plugin.
Update copyright year to 2018-2019 in LICENSE.MD
Change publishing license from "The Apache Software License, Version 2.0" to "The MIT License" for consistency.

* check params and init client before setting base url

* change setBaseUrl() to return boolean

fix: typo displacemnt => displacement (#438)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants