Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reorganize Telemetry releases 4.7.1, 4.7.2, 4.7.3 into 4.7.4 and above #463

Closed
wants to merge 13 commits into from

Conversation

harvsu
Copy link
Contributor

@harvsu harvsu commented Mar 12, 2020

To address back-porting issues with AndroidX and binary size issues with addition of WorkManager, revert those and other changes that occurred in Telemetry releases 4.7.1, 4.7.2 and 4.7.3 except #457, #443 and #444

Other changes need to be reverted as well because they are heavily intertwined in the commit chain and will be added back in future releases.
https://github.com/mapbox/mobile-telemetry/issues/537

Reverted changes will be added in further releases 5.0.0 and 5.1.0 along with fixes for the issues specified above.

Harsha Sura added 12 commits March 12, 2020 15:08
Add custom socket factory and set TrafficStats.setThreadStatsTag(1000) for configuration client(okhttpClient).

(cherry picked from commit 40b8f44)
* Fix obfuscation:

Prevent obfuscation of Event classes to keep properties in JSON schema unaltered.
Throw Assertion Error in Test App in case of POST failure for an event.
Set minifyEnabled true in build.gradle for debug build to make the test
app behave close to production app.
Add button on test app's main screen, which sends turnstile event on click.
Add @SerializedName annotation to Turnstile and Crash Event properties
to keep them consistent with other events.
Fix Location Schema test to ignore the properties(speed, course, floor,
speedAccuracy, courseAccuracy, and verticalAccuracy) that are
added in the backend but not incorporated into the SDK yet!

(cherry picked from commit 5f6d6ff)
Remove AndroidX imports and add imports for @keep from support library.
@harvsu harvsu changed the title Reorganize Telemetry releases 4.7.1, 4.7.2, 4.7.3 in 4.7.4 and above Reorganize Telemetry releases 4.7.1, 4.7.2, 4.7.3 into 4.7.4 and above Mar 12, 2020
@harvsu harvsu changed the title Reorganize Telemetry releases 4.7.1, 4.7.2, 4.7.3 into 4.7.4 and above WIP Reorganize Telemetry releases 4.7.1, 4.7.2, 4.7.3 into 4.7.4 and above Mar 12, 2020
Gradle Version : 5.6.4
Android Gradle Plugin Version : 3.5.3

(cherry picked from commit ac7dc73)
@harvsu harvsu changed the title WIP Reorganize Telemetry releases 4.7.1, 4.7.2, 4.7.3 into 4.7.4 and above Reorganize Telemetry releases 4.7.1, 4.7.2, 4.7.3 into 4.7.4 and above Mar 13, 2020
@harvsu harvsu requested review from nkukday and alfwatt March 13, 2020 00:58
@harvsu
Copy link
Contributor Author

harvsu commented Mar 17, 2020

Closing this because it is addressed in #464

@harvsu harvsu closed this Mar 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant