-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reorganize Telemetry releases 4.7.1, 4.7.2, 4.7.3 into 4.7.4 and above #463
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 5f6d6ff
This reverts commit fa7f7fa
This reverts commit 99441e2
This reverts commit 40b8f44
This reverts commit 39a3e65
This reverts commit ac7dc73
Add custom socket factory and set TrafficStats.setThreadStatsTag(1000) for configuration client(okhttpClient). (cherry picked from commit 40b8f44)
* Fix obfuscation: Prevent obfuscation of Event classes to keep properties in JSON schema unaltered. Throw Assertion Error in Test App in case of POST failure for an event. Set minifyEnabled true in build.gradle for debug build to make the test app behave close to production app. Add button on test app's main screen, which sends turnstile event on click. Add @SerializedName annotation to Turnstile and Crash Event properties to keep them consistent with other events. Fix Location Schema test to ignore the properties(speed, course, floor, speedAccuracy, courseAccuracy, and verticalAccuracy) that are added in the backend but not incorporated into the SDK yet! (cherry picked from commit 5f6d6ff)
Remove AndroidX imports and add imports for @keep from support library.
harvsu
changed the title
Reorganize Telemetry releases 4.7.1, 4.7.2, 4.7.3 in 4.7.4 and above
Reorganize Telemetry releases 4.7.1, 4.7.2, 4.7.3 into 4.7.4 and above
Mar 12, 2020
harvsu
changed the title
Reorganize Telemetry releases 4.7.1, 4.7.2, 4.7.3 into 4.7.4 and above
WIP Reorganize Telemetry releases 4.7.1, 4.7.2, 4.7.3 into 4.7.4 and above
Mar 12, 2020
Gradle Version : 5.6.4 Android Gradle Plugin Version : 3.5.3 (cherry picked from commit ac7dc73)
harvsu
changed the title
WIP Reorganize Telemetry releases 4.7.1, 4.7.2, 4.7.3 into 4.7.4 and above
Reorganize Telemetry releases 4.7.1, 4.7.2, 4.7.3 into 4.7.4 and above
Mar 13, 2020
Closing this because it is addressed in #464 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To address back-porting issues with AndroidX and binary size issues with addition of WorkManager, revert those and other changes that occurred in Telemetry releases 4.7.1, 4.7.2 and 4.7.3 except #457, #443 and #444
Other changes need to be reverted as well because they are heavily intertwined in the commit chain and will be added back in future releases.
https://github.com/mapbox/mobile-telemetry/issues/537
Reverted changes will be added in further releases 5.0.0 and 5.1.0 along with fixes for the issues specified above.