Address backwards compatibility issues with AndroidX #464
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## long-term-support #464 +/- ##
=======================================================
- Coverage 68.65% 68.36% -0.29%
Complexity 394 394
=======================================================
Files 69 69
Lines 2144 2156 +12
Branches 171 171
=======================================================
+ Hits 1472 1474 +2
- Misses 575 584 +9
- Partials 97 98 +1 |
harvsu
force-pushed
the
reorganize-releases-4.7.4_1.4.2
branch
from
cf89236
to
34bba45
Compare
harvsu
changed the title
harvsu
changed the title
harvsu
force-pushed
the
reorganize-releases-4.7.4_1.4.2
branch
from
f03db87
to
4be1934
Compare
harvsu
changed the title
Gradle Version : 5.6.4 Android Gradle Plugin Version : 3.5.3
Update version to 4.7.1 in package.json
Add custom socket factory and set TrafficStats.setThreadStatsTag(1000) for configuration client(okhttpClient).
* Fix obfuscation: Prevent obfuscation of Event classes to keep properties in JSON schema unaltered. Throw Assertion Error in Test App in case of POST failure for an event. Set minifyEnabled true in build.gradle for debug build to make the test app behave close to production app. Add button on test app's main screen, which sends turnstile event on click. Add @SerializedName annotation to Turnstile and Crash Event properties to keep them consistent with other events. Fix Location Schema test to ignore the properties(speed, course, floor, speedAccuracy, courseAccuracy, and verticalAccuracy) that are added in the backend but not incorporated into the SDK yet!
harvsu
force-pushed
the
reorganize-releases-4.7.4_1.4.2
branch
from
9547245
to
f3de6e1
Compare
nkukday
approved these changes
Mar 17, 2020
harvsu
force-pushed
the
reorganize-releases-4.7.4_1.4.2
branch
from
61e38a8
to
f3de6e1
Compare
Append -lts to name of the binary while publishing the binary size. Update Version in gradle.properties and package.json.
alfwatt
approved these changes
Mar 18, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry pick commits in #443 #444 #445 #457
To address back-porting issues with AndroidX, the current code base is adjusted to build SDKs with and with out AndroidX library.
https://stackoverflow.com/questions/55172932/android-x-backwards-compatibility
To achieve this, the releases are backtracked to Telem 4.7.0/Core 1.4.0 to maintain two different sets of code with and without AndroidX migration changes.
Telem 4.7.0/Core 1.4.0 is the latest release before which AndroidX was included.
https://github.com/mapbox/mapbox-events-android/tree/long-term-support is branched off at the commit where Telem 4.7.0/Core 1.4.0 release was tagged and this acts as a pseudo master for non AndroidX Code from here on.
master branch tracks the code with AndroidX and includes all new feature/code additions from now on. These new additions will be cherrypicked to https://github.com/mapbox/mapbox-events-android/tree/long-term-support as necessary.
Commits that occurred in releases Telem 4.7.1/Core 1.4.1, Telem 4.7.2 and Teleme 4.7.3(released so far) in master branch will be streamlined and reorganised in further releases as per https://github.com/mapbox/mobile-telemetry/issues/537