Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clean up debug pages #3596

Merged
merged 2 commits into from
Nov 11, 2016
Merged

Clean up debug pages #3596

merged 2 commits into from
Nov 11, 2016

Conversation

mourner
Copy link
Member

@mourner mourner commented Nov 11, 2016 •
edited
Loading

  • Remove bufferStats (which no longer exist), close Move buffer stats to a separate debug page  #2281.
  • Move index.html to debug.html, make index.html a minimal page.
  • Remove debug checkboxes and native compare shortcut from other debug pages (they were mostly copypasted and don't serve any purpose).
  • Add debug page linting to the lint task and .eslintrc for debug pages.
  • Fix indenting/whitespace/etc. lint errors.

@lucaswoj 👀

@mourner mourner mentioned this pull request Nov 11, 2016
Closed
lucaswoj
lucaswoj approved these changes Nov 11, 2016
View reviewed changes
Copy link
Contributor

@lucaswoj lucaswoj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is fantastic. Thank you.

@mourner mourner merged commit 95b0ca4 into master Nov 11, 2016
@mourner mourner deleted the cleaner-debug-pages branch November 11, 2016 20:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lucaswoj lucaswoj lucaswoj approved these changes

Assignees
No one assigned
Labels
refactoring 🏗️
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Move buffer stats to a separate debug page
2 participants
@mourner @lucaswoj