-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Opaque pass layers do not render correctly over heatmap + fill-extrusion layers #5831
Labels
Comments
+1 |
astojilj
added a commit
that referenced
this issue
Jul 7, 2019
and combinations/fill-extrusion-translucent--fill-opaque tests. Related to #5831
astojilj
added a commit
that referenced
this issue
Jul 9, 2019
and combinations/fill-extrusion-translucent--fill-opaque tests. Related to #5831
This is still an issue. Workaround by setting opacity of the layer that supposed to be in front of the heatmap to 0.99. |
Thanks @willrbc, will give this a try |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Layers drawn during the opaque pass (opaque background + opaque fill layers) cannot render correctly above offscreen texture-based layers (heatmap + fill-extrusion layers): they expect layers "under" them in the layer stack, drawn after them, to use depth testing. When rendering heatmap and fill-extrusion textures back to the map, depth testing is turned off, but it's not as simple as turning depth testing on because projections are done in the offscreen pass, so in the translucent pass the texture copies use a very simple viewport matrix, not the same projection matrices as the rest of the layers, so their depth comparison values wouldn't be relevant anyway. As in #2074, a workaround is to set the opaque layers' opacity to 0.99 so as to render them in the translucent pass, but the better fix would be to eliminate the opaque pass (#2074 (comment)).
The text was updated successfully, but these errors were encountered: