Render combination tests #5832
Merged
Render combination tests #5832
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
December 8, 2017 15:11
… sets its own depth mask correctly
jfirebaugh
approved these changes
Dec 12, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds 121 render tests in various combinations of layers. I felt compelled to add these in working on #5826, mostly to ensure that that PR (which eliminates all rendering based on assumed state, and forces renders to specify their own color/depth/stencil state) doesn't cause regressions, but also led to the discovery of #5831 and 5565087#r155843772. These tests add about 22 seconds to the render suite on my (at the time of testing, very busy) machine.
The
-opaque/-translucentnaming refers to the pass in which a layer is drawn, not necessarily the actual opacity of the layer in question: some of the-translucentlayers are actually translucent and some are not, depending on what made rendering results clearer.